Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: ui/latency/latency_info.cc

Issue 2914023002: Remove LatencyInfo::sequence_number. (May break metrics).
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/latency/latency_info.cc
diff --git a/ui/latency/latency_info.cc b/ui/latency/latency_info.cc
index ff1fffe2980b7911c877f50f63126de05145886c..2676a3515a197235417b84c881fd2075f2047cef 100644
--- a/ui/latency/latency_info.cc
+++ b/ui/latency/latency_info.cc
@@ -168,7 +168,6 @@ void LatencyInfo::CopyLatencyFrom(const LatencyInfo& other,
if (lc.first.first == type) {
AddLatencyNumberWithTimestamp(lc.first.first,
lc.first.second,
- lc.second.sequence_number,
lc.second.event_time,
lc.second.event_count);
}
@@ -190,7 +189,6 @@ void LatencyInfo::AddNewLatencyFrom(const LatencyInfo& other) {
if (!FindLatency(lc.first.first, lc.first.second, NULL)) {
AddLatencyNumberWithTimestamp(lc.first.first,
lc.first.second,
- lc.second.sequence_number,
lc.second.event_time,
lc.second.event_count);
}
@@ -207,36 +205,30 @@ void LatencyInfo::AddNewLatencyFrom(const LatencyInfo& other) {
terminated_ = other.terminated();
}
-void LatencyInfo::AddLatencyNumber(LatencyComponentType component,
- int64_t id,
- int64_t component_sequence_number) {
- AddLatencyNumberWithTimestampImpl(component, id, component_sequence_number,
- base::TimeTicks::Now(), 1, nullptr);
+void LatencyInfo::AddLatencyNumber(LatencyComponentType component, int64_t id) {
+ AddLatencyNumberWithTimestampImpl(component, id, base::TimeTicks::Now(), 1,
+ nullptr);
}
void LatencyInfo::AddLatencyNumberWithTraceName(
LatencyComponentType component,
int64_t id,
- int64_t component_sequence_number,
const char* trace_name_str) {
- AddLatencyNumberWithTimestampImpl(component, id, component_sequence_number,
- base::TimeTicks::Now(), 1, trace_name_str);
+ AddLatencyNumberWithTimestampImpl(component, id, base::TimeTicks::Now(), 1,
+ trace_name_str);
}
void LatencyInfo::AddLatencyNumberWithTimestamp(
LatencyComponentType component,
int64_t id,
- int64_t component_sequence_number,
base::TimeTicks time,
uint32_t event_count) {
- AddLatencyNumberWithTimestampImpl(component, id, component_sequence_number,
- time, event_count, nullptr);
+ AddLatencyNumberWithTimestampImpl(component, id, time, event_count, nullptr);
}
void LatencyInfo::AddLatencyNumberWithTimestampImpl(
LatencyComponentType component,
int64_t id,
- int64_t component_sequence_number,
base::TimeTicks time,
uint32_t event_count,
const char* trace_name_str) {
@@ -293,12 +285,9 @@ void LatencyInfo::AddLatencyNumberWithTimestampImpl(
LatencyMap::key_type key = std::make_pair(component, id);
LatencyMap::iterator it = latency_components_.find(key);
if (it == latency_components_.end()) {
- LatencyComponent info = {component_sequence_number, time, event_count, time,
- time};
+ LatencyComponent info = {time, event_count, time, time};
latency_components_[key] = info;
} else {
- it->second.sequence_number = std::max(component_sequence_number,
- it->second.sequence_number);
uint32_t new_count = event_count + it->second.event_count;
if (event_count > 0 && new_count != 0) {
// Do a weighted average, so that the new event_time is the average of
@@ -341,8 +330,6 @@ LatencyInfo::AsTraceableData() {
"time",
static_cast<double>(lc.second.event_time.ToInternalValue()));
component_info->SetDouble("count", lc.second.event_count);
- component_info->SetDouble("sequence_number",
- lc.second.sequence_number);
record_data->Set(GetComponentName(lc.first.first),
std::move(component_info));
}

Powered by Google App Engine
This is Rietveld 408576698