Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: content/browser/renderer_host/input/render_widget_host_latency_tracker.cc

Issue 2914023002: Remove LatencyInfo::sequence_number. (May break metrics).
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
diff --git a/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc b/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
index c73061541bd58dbda453d4085d1c73c5ee948c73..99737aa8b4911456f3227d67c19c23ad8efff562 100644
--- a/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
+++ b/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
@@ -69,7 +69,6 @@ void AddLatencyInfoComponentIds(LatencyInfo* latency,
latency->AddLatencyNumberWithTimestamp(
new_components_key[i].first,
new_components_key[i].second,
- new_components_value[i].sequence_number,
new_components_value[i].event_time,
new_components_value[i].event_count);
}
@@ -140,7 +139,6 @@ void RecordEQTAccuracy(base::TimeDelta queueing_time,
RenderWidgetHostLatencyTracker::RenderWidgetHostLatencyTracker()
: ukm_source_id_(-1),
- last_event_id_(0),
latency_component_id_(0),
device_scale_factor_(1),
has_seen_first_gesture_scroll_update_(false),
@@ -152,10 +150,8 @@ RenderWidgetHostLatencyTracker::~RenderWidgetHostLatencyTracker() {}
void RenderWidgetHostLatencyTracker::Initialize(int routing_id,
int process_id) {
- DCHECK_EQ(0, last_event_id_);
DCHECK_EQ(0, latency_component_id_);
- last_event_id_ = static_cast<int64_t>(process_id) << 32;
- latency_component_id_ = routing_id | last_event_id_;
+ latency_component_id_ = routing_id | static_cast<int64_t>(process_id) << 32;
}
void RenderWidgetHostLatencyTracker::ComputeInputLatencyHistograms(
@@ -299,14 +295,13 @@ void RenderWidgetHostLatencyTracker::OnInputEvent(
latency->AddLatencyNumberWithTimestamp(
ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT,
0,
- 0,
timestamp_original,
1);
}
latency->AddLatencyNumberWithTraceName(
ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT, latency_component_id_,
- ++last_event_id_, WebInputEvent::GetName(event.GetType()));
+ WebInputEvent::GetName(event.GetType()));
if (event.GetType() == blink::WebInputEvent::kGestureScrollBegin) {
has_seen_first_gesture_scroll_update_ = false;
@@ -321,8 +316,8 @@ void RenderWidgetHostLatencyTracker::OnInputEvent(
has_seen_first_gesture_scroll_update_
? ui::INPUT_EVENT_LATENCY_SCROLL_UPDATE_ORIGINAL_COMPONENT
: ui::INPUT_EVENT_LATENCY_FIRST_SCROLL_UPDATE_ORIGINAL_COMPONENT,
- latency_component_id_, original_component.sequence_number,
- original_component.event_time, original_component.event_count);
+ latency_component_id_, original_component.event_time,
+ original_component.event_count);
}
has_seen_first_gesture_scroll_update_ = true;
@@ -352,12 +347,12 @@ void RenderWidgetHostLatencyTracker::OnInputEventAck(
}
}
- latency->AddLatencyNumber(ui::INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT, 0, 0);
+ latency->AddLatencyNumber(ui::INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT, 0);
// If this event couldn't have caused a gesture event, and it didn't trigger
// rendering, we're done processing it.
if (!rendering_scheduled) {
latency->AddLatencyNumber(
- ui::INPUT_EVENT_LATENCY_TERMINATED_NO_SWAP_COMPONENT, 0, 0);
+ ui::INPUT_EVENT_LATENCY_TERMINATED_NO_SWAP_COMPONENT, 0);
}
ComputeInputLatencyHistograms(event.GetType(), latency_component_id_,

Powered by Google App Engine
This is Rietveld 408576698