Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10603)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame_browsertest.cc

Issue 2914013004: Propagate auto-resize viewport values to OOPIF processes (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame_browsertest.cc
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame_browsertest.cc b/content/browser/frame_host/render_widget_host_view_child_frame_browsertest.cc
index b27892cec6dad47a2087392775941d364214bae4..0410c41947b3bb8dc2de0fbb333cb60778b25791 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame_browsertest.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame_browsertest.cc
@@ -3,7 +3,9 @@
// found in the LICENSE file.
#include "base/macros.h"
+#include "content/browser/frame_host/frame_tree_node.h"
#include "content/browser/web_contents/web_contents_impl.h"
+#include "content/common/view_messages.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test_utils.h"
@@ -15,6 +17,7 @@
#include "content/test/test_content_browser_client.h"
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
+#include "ui/gfx/geometry/size.h"
namespace content {
@@ -73,4 +76,42 @@ IN_PROC_BROWSER_TEST_F(RenderWidgetHostViewChildFrameTest, Screen) {
base::Unretained(this)));
}
+// Test that auto-resize sizes in the top frame are propagated to OOPIF
+// RenderWidgetHostViews.
alexmos 2017/06/02 00:45:22 nit: might be useful to include the bug reference
kenrb 2017/06/02 15:44:46 Done.
+IN_PROC_BROWSER_TEST_F(RenderWidgetHostViewChildFrameTest,
+ ChildFrameAutoResizeUpdateTest) {
alexmos 2017/06/02 00:45:22 nit: I'd drop the "Test" suffix from the name, as
kenrb 2017/06/02 15:44:46 Done.
+ EXPECT_TRUE(NavigateToURL(
+ shell(), embedded_test_server()->GetURL(
+ "a.com", "/cross_site_iframe_factory.html?a(b)")));
+
+ FrameTreeNode* root = static_cast<WebContentsImpl*>(shell()->web_contents())
+ ->GetFrameTree()
+ ->root();
+ root->current_frame_host()->render_view_host()->EnableAutoResize(
+ gfx::Size(0, 0), gfx::Size(100, 100));
+
+ RenderWidgetHostView* rwhv =
+ root->child_at(0)->current_frame_host()->GetRenderWidgetHost()->GetView();
+
+ // Fake an auto-resize update from the parent renderer.
+ int routing_id =
+ root->current_frame_host()->GetRenderWidgetHost()->GetRoutingID();
+ ViewHostMsg_UpdateRect_Params params;
+ params.view_size = gfx::Size(75, 75);
+ params.flags = 0;
+ root->current_frame_host()->GetRenderWidgetHost()->OnMessageReceived(
+ ViewHostMsg_UpdateRect(routing_id, params));
+
+ // Yield to let the delayed auto-resizing processing in RenderWidgetHostImpl
+ // to complete.
+ base::RunLoop run_loop;
+ base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
+ run_loop.QuitClosure());
+ run_loop.Run();
+
+ // The child frame's RenderWidgetHostView should now use the auto-resize value
+ // for its visible viewport.
+ EXPECT_EQ(gfx::Size(75, 75), rwhv->GetVisibleViewportSize());
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698