Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2913983003: Stop passing removed parameter to create_snapshot_bin.py to fix GYP/Dartium build. (Closed)

Created:
3 years, 6 months ago by rmacnak
Modified:
3 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop passing removed parameter to create_snapshot_bin.py to fix GYP/Dartium build. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/7f7689750ff824392da7cdda7ceb1a11ca3509f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M runtime/bin/bin.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 6 months ago (2017-05-31 23:29:46 UTC) #2
siva
lgtm
3 years, 6 months ago (2017-06-01 00:04:09 UTC) #3
rmacnak
3 years, 6 months ago (2017-06-01 00:04:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f7689750ff824392da7cdda7ceb1a11ca3509f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698