Add negation to single-identifier tests in status files.

tests/standalone/status_expression_test.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 
 import "../../tools/testing/dart/environment.dart";
 import "../../tools/testing/dart/status_expression.dart";
 
 class TestEnvironment implements Environment {
   final Map<String, String> _values;
 
   TestEnvironment(this._values);
 
   /// Looks up the value of the variable with [name].
   String lookUp(String name) => _values[name];
 
   operator []=(String key, String value) => _values[key] = value;
 }
 
 main() {
   testExpression();
   testSyntaxError();
   testBoolean();
+  testNotBoolean();
   testNotEqual();
 }
 
 void testExpression() {
   var expression = Expression
       .parse(r" $mode == debug && ($arch == chromium || $arch == dartc) ");
   Expect.equals(
       r"(($mode == debug) && (($arch == chromium) || ($arch == dartc)))",
       expression.toString());
 
@@ skipping 34 matching lines @@
   environment["checked"] = "false";
   Expect.isTrue(expression.evaluate(environment));
   environment["mode"] = "debug";
   Expect.isFalse(expression.evaluate(environment));
   environment["arch"] = "arm";
   Expect.isFalse(expression.evaluate(environment));
   environment["checked"] = "true";
   Expect.isFalse(expression.evaluate(environment));
 }
 
+void testNotBoolean() {
+  var expression =
+      Expression.parse(r"  $arch == ia32 && ! $unchecked || $mode == release ");
+  Expect.equals(
+      r"((($arch == ia32) && (bool ! $unchecked)) || ($mode == release))",
+      expression.toString());
+
+  var environment = <String, dynamic>{

[Bob Nystrom, 2017/06/01 23:07:46]

This map needs to be wrapped in new TestEnvironment() now that my change landed
yesterday. (Also, the type arguments aren't needed.)

[Lasse Reichstein Nielsen, 2017/06/07 08:51:48]

Done.

+    "arch": "ia32",
+    "unchecked": false,

[Bob Nystrom, 2017/06/01 23:07:45]

Nit: Would you mind using "checked" for this?

It seems a little confusing to use the negated term in the test when the whole
point of "!" is so we don't need negated terms.

[Lasse Reichstein Nielsen, 2017/06/07 08:51:48]

Sure. This was just the "minimal diff" from the test above :)

+    "mode": "debug"
+  };
+
+  Expect.isTrue(expression.evaluate(environment));
+  environment["mode"] = "release";
+  Expect.isTrue(expression.evaluate(environment));
+  environment["unchecked"] = true;

[Bob Nystrom, 2017/06/01 23:07:45]

"true" and "false" need to be explicitly stringified now. The environment
uniformly treats all values as strings.

[Lasse Reichstein Nielsen, 2017/06/07 08:51:48]

Done.

+  Expect.isTrue(expression.evaluate(environment));
+  environment["mode"] = "debug";
+  Expect.isFalse(expression.evaluate(environment));
+  environment["arch"] = "arm";
+  Expect.isFalse(expression.evaluate(environment));
+  environment["unchecked"] = false;
+  Expect.isFalse(expression.evaluate(environment));
+}
+
 void testNotEqual() {
   // Test the != operator.
   var expression = Expression.parse(r"$compiler == dart2js && $runtime != ie9");
   Expect.equals(
       r"(($compiler == dart2js) && ($runtime != ie9))", expression.toString());
 
   // Test BooleanExpression.evaluate().
   var environment = new TestEnvironment({
     "compiler": "none",
     "runtime": "ie9",
   });
 
   Expect.isFalse(expression.evaluate(environment));
   environment["runtime"] = "chrome";
   Expect.isFalse(expression.evaluate(environment));
 
   environment["compiler"] = "dart2js";
   environment["runtime"] = "ie9";
   Expect.isFalse(expression.evaluate(environment));
   environment["runtime"] = "chrome";
   Expect.isTrue(expression.evaluate(environment));
 }