Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 291393002: Make v8::TryCatch able to consume natively thrown exceptions (again). (Closed)

Created:
6 years, 7 months ago by Michael Starzinger
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Make v8::TryCatch able to consume natively thrown exceptions (again). R=yangguo@chromium.org BUG=chromium:362388 TEST=cctest/test-api/TryCatchNative LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -11 lines) Patch
M src/api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +54 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
6 years, 7 months ago (2014-05-22 13:18:12 UTC) #1
Yang
On 2014/05/22 13:18:12, Michael Starzinger wrote: lgtm.
6 years, 7 months ago (2014-05-22 14:07:24 UTC) #2
Michael Starzinger
6 years, 7 months ago (2014-05-23 08:34:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21456 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698