Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 2913903002: Modify autocompletion test case to work with new feature added (Closed)

Created:
3 years, 6 months ago by maxkim
Modified:
3 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Modify autocompletion test case to work with new feature added Request offset and Length of plugin response must line-up if main Dart autocompletion has suggestions already. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/311dd0bb0c0c8264bc9637dfe38222d3a70f7b95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
maxkim
3 years, 6 months ago (2017-05-30 23:39:29 UTC) #3
Brian Wilkerson
lgtm
3 years, 6 months ago (2017-05-30 23:57:44 UTC) #4
maxkim
3 years, 6 months ago (2017-05-31 00:14:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
311dd0bb0c0c8264bc9637dfe38222d3a70f7b95 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698