src/crankshaft/x64/lithium-codegen-x64.cc - Issue 2913783002: [builtins] Begin removing CodeFactory accessors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/x64/lithium-codegen-x64.cc

Issue 2913783002: [builtins] Begin removing CodeFactory accessors (Closed)

Patch Set: V8_EXPORT_PRIVATE Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/x64/lithium-codegen-x64.cc

diff --git a/src/crankshaft/x64/lithium-codegen-x64.cc b/src/crankshaft/x64/lithium-codegen-x64.cc

index 13a3e3fabfde626791760a134e6619fa35c83f19..cf4cd11d34fad604af6ffb1899b631752aca3997 100644

--- a/src/crankshaft/x64/lithium-codegen-x64.cc

+++ b/src/crankshaft/x64/lithium-codegen-x64.cc

@@ -5088,7 +5088,7 @@ void LCodeGen::DoTypeof(LTypeof* instr) {

__ Move(rax, isolate()->factory()->number_string());

__ jmp(&end);

__ bind(&do_call);

- Callable callable = CodeFactory::Typeof(isolate());

+ Callable callable = Builtins::CallableFor(isolate(), Builtins::kTypeof);

CallCode(callable.code(), RelocInfo::CODE_TARGET, instr);

__ bind(&end);

}