src/crankshaft/hydrogen.cc - Issue 2913783002: [builtins] Begin removing CodeFactory accessors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2913783002: [builtins] Begin removing CodeFactory accessors (Closed)

Patch Set: V8_EXPORT_PRIVATE Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index f176de3dce55222d345ba87cd1ea5fa772806c87..753e09e0260a67bcf7a0502e0598c0d5d1d51c0b 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -11542,7 +11542,7 @@ void HOptimizedGraphBuilder::GenerateToString(CallRuntime* call) {

if (input->type().IsString()) {

return ast_context()->ReturnValue(input);

} else {

- Callable callable = CodeFactory::ToString(isolate());

+ Callable callable = Builtins::CallableFor(isolate(), Builtins::kToString);

HValue* stub = Add<HConstant>(callable.code());

HValue* values[] = {input};

HInstruction* result = New<HCallWithDescriptor>(