Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: src/interpreter/interpreter-intrinsics-generator.cc

Issue 2913783002: [builtins] Begin removing CodeFactory accessors (Closed)
Patch Set: V8_EXPORT_PRIVATE Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/interpreter-generator.cc ('k') | test/cctest/compiler/test-code-assembler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 the V8 project authors. All rights reserved. 1 // Copyright 2017 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/interpreter-intrinsics-generator.h" 5 #include "src/interpreter/interpreter-intrinsics-generator.h"
6 6
7 #include "src/allocation.h" 7 #include "src/allocation.h"
8 #include "src/builtins/builtins.h" 8 #include "src/builtins/builtins.h"
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/frames.h" 10 #include "src/frames.h"
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 CodeFactory::HasProperty(isolate())); 286 CodeFactory::HasProperty(isolate()));
287 } 287 }
288 288
289 Node* IntrinsicsGenerator::SubString(Node* input, Node* arg_count, 289 Node* IntrinsicsGenerator::SubString(Node* input, Node* arg_count,
290 Node* context) { 290 Node* context) {
291 return IntrinsicAsStubCall(input, context, CodeFactory::SubString(isolate())); 291 return IntrinsicAsStubCall(input, context, CodeFactory::SubString(isolate()));
292 } 292 }
293 293
294 Node* IntrinsicsGenerator::ToString(Node* input, Node* arg_count, 294 Node* IntrinsicsGenerator::ToString(Node* input, Node* arg_count,
295 Node* context) { 295 Node* context) {
296 return IntrinsicAsStubCall(input, context, CodeFactory::ToString(isolate())); 296 return IntrinsicAsStubCall(
297 input, context, Builtins::CallableFor(isolate(), Builtins::kToString));
297 } 298 }
298 299
299 Node* IntrinsicsGenerator::ToLength(Node* input, Node* arg_count, 300 Node* IntrinsicsGenerator::ToLength(Node* input, Node* arg_count,
300 Node* context) { 301 Node* context) {
301 return IntrinsicAsStubCall(input, context, CodeFactory::ToLength(isolate())); 302 return IntrinsicAsStubCall(input, context, CodeFactory::ToLength(isolate()));
302 } 303 }
303 304
304 Node* IntrinsicsGenerator::ToInteger(Node* input, Node* arg_count, 305 Node* IntrinsicsGenerator::ToInteger(Node* input, Node* arg_count,
305 Node* context) { 306 Node* context) {
306 return IntrinsicAsStubCall(input, context, CodeFactory::ToInteger(isolate())); 307 return IntrinsicAsStubCall(input, context, CodeFactory::ToInteger(isolate()));
307 } 308 }
308 309
309 Node* IntrinsicsGenerator::ToNumber(Node* input, Node* arg_count, 310 Node* IntrinsicsGenerator::ToNumber(Node* input, Node* arg_count,
310 Node* context) { 311 Node* context) {
311 return IntrinsicAsStubCall(input, context, CodeFactory::ToNumber(isolate())); 312 return IntrinsicAsStubCall(input, context, CodeFactory::ToNumber(isolate()));
312 } 313 }
313 314
314 Node* IntrinsicsGenerator::ToObject(Node* input, Node* arg_count, 315 Node* IntrinsicsGenerator::ToObject(Node* input, Node* arg_count,
315 Node* context) { 316 Node* context) {
316 return IntrinsicAsStubCall(input, context, CodeFactory::ToObject(isolate())); 317 return IntrinsicAsStubCall(
318 input, context, Builtins::CallableFor(isolate(), Builtins::kToObject));
317 } 319 }
318 320
319 Node* IntrinsicsGenerator::Call(Node* args_reg, Node* arg_count, 321 Node* IntrinsicsGenerator::Call(Node* args_reg, Node* arg_count,
320 Node* context) { 322 Node* context) {
321 // First argument register contains the function target. 323 // First argument register contains the function target.
322 Node* function = __ LoadRegister(args_reg); 324 Node* function = __ LoadRegister(args_reg);
323 325
324 // Receiver is the second runtime call argument. 326 // Receiver is the second runtime call argument.
325 Node* receiver_reg = __ NextRegister(args_reg); 327 Node* receiver_reg = __ NextRegister(args_reg);
326 Node* receiver_arg = __ RegisterLocation(receiver_reg); 328 Node* receiver_arg = __ RegisterLocation(receiver_reg);
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 Node* comparison = __ Word32Equal(actual, __ Int32Constant(expected)); 462 Node* comparison = __ Word32Equal(actual, __ Int32Constant(expected));
461 __ GotoIf(comparison, &match); 463 __ GotoIf(comparison, &match);
462 __ Abort(kWrongArgumentCountForInvokeIntrinsic); 464 __ Abort(kWrongArgumentCountForInvokeIntrinsic);
463 __ Goto(&match); 465 __ Goto(&match);
464 __ BIND(&match); 466 __ BIND(&match);
465 } 467 }
466 468
467 } // namespace interpreter 469 } // namespace interpreter
468 } // namespace internal 470 } // namespace internal
469 } // namespace v8 471 } // namespace v8
OLDNEW
« no previous file with comments | « src/interpreter/interpreter-generator.cc ('k') | test/cctest/compiler/test-code-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698