third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h - Issue 2913773002: [WIP][b:eae_mywip_paint] Paint Selection NG.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h

Issue 2913773002: [WIP][b:eae_mywip_paint] Paint Selection NG.

Patch Set: update Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/LayoutSelection.cpp ('K') | « third_party/WebKit/Source/core/editing/LayoutSelectionTest.cpp ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.cc » ('j') | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h

index 9f295706ea0b3e1cdb2b3afe22068a496810b9bc..1e2a20a19a197d981a08c157521591320d99a30a 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder.h

@@ -32,6 +32,9 @@ class CORE_EXPORT NGInlineItemsBuilder {

public:

explicit NGInlineItemsBuilder(Vector<NGInlineItem>* items) : items_(items) {}

+ explicit NGInlineItemsBuilder(Vector<NGInlineItem>* items,

+ Vector<int>* offset_mapping)

+ : items_(items), offset_mapping_(offset_mapping) {}

kojii 2017/06/16 11:25:56 this isn't for review, correct?

~NGInlineItemsBuilder();

String ToString();

@@ -79,6 +82,7 @@ class CORE_EXPORT NGInlineItemsBuilder {

private:

Vector<NGInlineItem>* items_;

StringBuilder text_;

+ Vector<int>* offset_mapping_ = nullptr;

typedef struct OnExitNode {

LayoutObject* node;