Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: tests/compiler/dart2js/equivalence/check_helpers.dart

Issue 2913713004: Add model test of CodegenWorldBuilder to compile_from_dill_test (Closed)
Patch Set: So much patch set for so small a typo. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/equivalence/check_helpers.dart
diff --git a/tests/compiler/dart2js/equivalence/check_helpers.dart b/tests/compiler/dart2js/equivalence/check_helpers.dart
index a38b06ad3f40cefacab2c2d075eb72148b6e03ab..c7fff7e4252873cb67fd53ad5440741c2936493b 100644
--- a/tests/compiler/dart2js/equivalence/check_helpers.dart
+++ b/tests/compiler/dart2js/equivalence/check_helpers.dart
@@ -406,13 +406,21 @@ void checkMaps(Map map1, Map map2, String messagePrefix, bool sameKey(a, b),
bool sameValue(a, b),
{bool failOnUnfound: true,
bool failOnMismatch: true,
+ bool keyFilter(key),
bool verbose: false,
String keyToString(key): defaultToString,
String valueToString(key): defaultToString}) {
List<List> common = <List>[];
List unfound = [];
List<List> mismatch = <List>[];
- Set remaining = computeSetDifference(map1.keys, map2.keys, common, unfound,
+
+ Iterable keys1 = map1.keys;
+ Iterable keys2 = map2.keys;
+ if (keyFilter != null) {
+ keys1 = keys1.where(keyFilter);
+ keys2 = keys2.where(keyFilter);
+ }
+ Set remaining = computeSetDifference(keys1, keys2, common, unfound,
sameElement: sameKey, checkElements: (k1, k2) {
var v1 = map1[k1];
var v2 = map2[k2];
« no previous file with comments | « tests/compiler/dart2js/equivalence/check_functions.dart ('k') | tests/compiler/dart2js/kernel/closed_world_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698