Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3360)

Unified Diff: tests/compiler/dart2js/equivalence/check_functions.dart

Issue 2913713004: Add model test of CodegenWorldBuilder to compile_from_dill_test (Closed)
Patch Set: So much patch set for so small a typo. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/equivalence/check_functions.dart
diff --git a/tests/compiler/dart2js/equivalence/check_functions.dart b/tests/compiler/dart2js/equivalence/check_functions.dart
index 638a9fd9ddc1d25643272b6f7d63e8fb11015ddd..d666d995efffea7c27a28f2bb3561a50cbf173a9 100644
--- a/tests/compiler/dart2js/equivalence/check_functions.dart
+++ b/tests/compiler/dart2js/equivalence/check_functions.dart
@@ -15,6 +15,7 @@ import 'package:compiler/src/elements/elements.dart';
import 'package:compiler/src/elements/entities.dart';
import 'package:compiler/src/enqueue.dart';
import 'package:compiler/src/js_backend/backend_usage.dart';
+import 'package:compiler/src/js_backend/enqueuer.dart';
import 'package:compiler/src/js_backend/native_data.dart';
import 'package:compiler/src/js_backend/interceptor_data.dart';
import 'package:compiler/src/serialization/equivalence.dart';
@@ -615,6 +616,10 @@ bool areInstancesEquivalent(Instance instance1, Instance instance2,
instance1.isRedirection == instance2.isRedirection;
}
+bool areAbstractUsagesEquivalent(AbstractUsage usage1, AbstractUsage usage2) {
+ return usage1.hasSameUsage(usage2);
+}
+
void checkResolutionEnqueuers(
BackendUsage backendUsage1,
BackendUsage backendUsage2,
@@ -623,20 +628,20 @@ void checkResolutionEnqueuers(
{bool elementEquivalence(Entity a, Entity b): areElementsEquivalent,
bool typeEquivalence(DartType a, DartType b): areTypesEquivalent,
bool elementFilter(Element element),
- bool verbose: false}) {
+ bool verbose: false,
+ bool skipClassUsageTesting: false}) {
+ elementFilter ??= (_) => true;
+
ResolutionWorldBuilderBase worldBuilder1 = enqueuer1.worldBuilder;
ResolutionWorldBuilderBase worldBuilder2 = enqueuer2.worldBuilder;
- checkSets(
- enqueuer1.worldBuilder.instantiatedTypes,
- enqueuer2.worldBuilder.instantiatedTypes,
- "Instantiated types mismatch",
- typeEquivalence,
+ checkSets(worldBuilder1.instantiatedTypes, worldBuilder2.instantiatedTypes,
+ "Instantiated types mismatch", typeEquivalence,
verbose: verbose);
checkSets(
- enqueuer1.worldBuilder.directlyInstantiatedClasses,
- enqueuer2.worldBuilder.directlyInstantiatedClasses,
+ worldBuilder1.directlyInstantiatedClasses,
+ worldBuilder2.directlyInstantiatedClasses,
"Directly instantiated classes mismatch",
elementEquivalence,
verbose: verbose);
@@ -651,12 +656,49 @@ void checkResolutionEnqueuers(
verbose: verbose);
checkSets(enqueuer1.processedEntities, enqueuer2.processedEntities,
- "Processed element mismatch", elementEquivalence, elementFilter: (e) {
- return elementFilter != null ? elementFilter(e) : true;
- }, verbose: verbose);
+ "Processed element mismatch", elementEquivalence,
+ elementFilter: elementFilter, verbose: verbose);
- checkSets(enqueuer1.worldBuilder.isChecks, enqueuer2.worldBuilder.isChecks,
- "Is-check mismatch", typeEquivalence,
+ checkSets(worldBuilder1.isChecks, worldBuilder2.isChecks, "Is-check mismatch",
+ typeEquivalence,
+ verbose: verbose);
+
+ checkSets(worldBuilder1.closurizedMembers, worldBuilder2.closurizedMembers,
+ "closurizedMembers", elementEquivalence,
+ verbose: verbose);
+ checkSets(worldBuilder1.fieldSetters, worldBuilder2.fieldSetters,
+ "fieldSetters", elementEquivalence,
+ verbose: verbose);
+ checkSets(
+ worldBuilder1.methodsNeedingSuperGetter,
+ worldBuilder2.methodsNeedingSuperGetter,
+ "methodsNeedingSuperGetter",
+ elementEquivalence,
+ verbose: verbose);
+
+ if (!skipClassUsageTesting) {
+ checkMaps(
+ worldBuilder1.classUsageForTesting,
+ worldBuilder2.classUsageForTesting,
+ 'classUsageForTesting',
+ elementEquivalence,
+ areAbstractUsagesEquivalent,
+ verbose: verbose);
+ }
+ checkMaps(
+ worldBuilder1.staticMemberUsageForTesting,
+ worldBuilder2.staticMemberUsageForTesting,
+ 'staticMemberUsageForTesting',
+ elementEquivalence,
+ areAbstractUsagesEquivalent,
+ keyFilter: elementFilter,
+ verbose: verbose);
+ checkMaps(
+ worldBuilder1.instanceMemberUsageForTesting,
+ worldBuilder2.instanceMemberUsageForTesting,
+ 'instanceMemberUsageForTesting',
+ elementEquivalence,
+ areAbstractUsagesEquivalent,
verbose: verbose);
Expect.equals(backendUsage1.isInvokeOnUsed, backendUsage2.isInvokeOnUsed,
@@ -672,3 +714,79 @@ void checkResolutionEnqueuers(
Expect.equals(backendUsage1.isIsolateInUse, backendUsage2.isIsolateInUse,
"JavaScriptBackend.hasIsolateSupport mismatch");
}
+
+void checkCodegenEnqueuers(CodegenEnqueuer enqueuer1, CodegenEnqueuer enqueuer2,
+ {bool elementEquivalence(Entity a, Entity b): areElementsEquivalent,
+ bool typeEquivalence(DartType a, DartType b): areTypesEquivalent,
+ bool elementFilter(Element element),
+ bool verbose: false}) {
+ CodegenWorldBuilderImpl worldBuilder1 = enqueuer1.worldBuilder;
+ CodegenWorldBuilderImpl worldBuilder2 = enqueuer2.worldBuilder;
+
+ checkSets(worldBuilder1.instantiatedTypes, worldBuilder2.instantiatedTypes,
+ "Instantiated types mismatch", typeEquivalence,
+ verbose: verbose);
+
+ checkSets(
+ worldBuilder1.directlyInstantiatedClasses,
+ worldBuilder2.directlyInstantiatedClasses,
+ "Directly instantiated classes mismatch",
+ elementEquivalence,
+ verbose: verbose);
+
+ checkSets(enqueuer1.processedEntities, enqueuer2.processedEntities,
+ "Processed element mismatch", elementEquivalence, elementFilter: (e) {
+ return elementFilter != null ? elementFilter(e) : true;
+ }, verbose: verbose);
+
+ checkSets(worldBuilder1.isChecks, worldBuilder2.isChecks, "Is-check mismatch",
+ typeEquivalence,
+ verbose: verbose);
+
+ checkSets(
+ worldBuilder1.allReferencedStaticFields,
+ worldBuilder2.allReferencedStaticFields,
+ "Directly instantiated classes mismatch",
+ elementEquivalence,
+ verbose: verbose);
+ checkSets(worldBuilder1.closurizedMembers, worldBuilder2.closurizedMembers,
+ "closurizedMembers", elementEquivalence,
+ verbose: verbose);
+ checkSets(worldBuilder1.processedClasses, worldBuilder2.processedClasses,
+ "processedClasses", elementEquivalence,
+ verbose: verbose);
+ checkSets(
+ worldBuilder1.methodsNeedingSuperGetter,
+ worldBuilder2.methodsNeedingSuperGetter,
+ "methodsNeedingSuperGetter",
+ elementEquivalence,
+ verbose: verbose);
+ checkSets(
+ worldBuilder1.staticFunctionsNeedingGetter,
+ worldBuilder2.staticFunctionsNeedingGetter,
+ "staticFunctionsNeedingGetter",
+ elementEquivalence,
+ verbose: verbose);
+
+ checkMaps(
+ worldBuilder1.classUsageForTesting,
+ worldBuilder2.classUsageForTesting,
+ 'classUsageForTesting',
+ elementEquivalence,
+ areAbstractUsagesEquivalent,
+ verbose: verbose);
+ checkMaps(
+ worldBuilder1.staticMemberUsageForTesting,
+ worldBuilder2.staticMemberUsageForTesting,
+ 'staticMemberUsageForTesting',
+ elementEquivalence,
+ areAbstractUsagesEquivalent,
+ verbose: verbose);
+ checkMaps(
+ worldBuilder1.instanceMemberUsageForTesting,
+ worldBuilder2.instanceMemberUsageForTesting,
+ 'instanceMemberUsageForTesting',
+ elementEquivalence,
+ areAbstractUsagesEquivalent,
+ verbose: verbose);
+}
« no previous file with comments | « pkg/compiler/lib/src/universe/resolution_world_builder.dart ('k') | tests/compiler/dart2js/equivalence/check_helpers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698