Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2913713004: Add model test of CodegenWorldBuilder to compile_from_dill_test (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add model test of CodegenWorldBuilder to compile_from_dill_test R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b97d158b9a729e3ade92004258f5bd8b5b0f2e9c

Patch Set 1 #

Total comments: 8

Patch Set 2 : So much patch set for so small a typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -30 lines) Patch
M pkg/compiler/lib/src/enqueue.dart View 3 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/codegen_world_builder.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/member_usage.dart View 1 7 chunks +15 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/equivalence/check_functions.dart View 1 5 chunks +131 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/equivalence/check_helpers.dart View 1 1 chunk +9 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 1 chunk +6 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 5 chunks +10 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/kernel/compiler_helper.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-05-30 13:52:57 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2913713004/diff/1/tests/compiler/dart2js/equivalence/check_functions.dart File tests/compiler/dart2js/equivalence/check_functions.dart (right): https://codereview.chromium.org/2913713004/diff/1/tests/compiler/dart2js/equivalence/check_functions.dart#newcode675 tests/compiler/dart2js/equivalence/check_functions.dart:675: worldBuilder1.classUsageForTesting, worldBuilder2 https://codereview.chromium.org/2913713004/diff/1/tests/compiler/dart2js/equivalence/check_functions.dart#newcode682 tests/compiler/dart2js/equivalence/check_functions.dart:682: worldBuilder1.staticMemberUsageForTesting, 2 https://codereview.chromium.org/2913713004/diff/1/tests/compiler/dart2js/equivalence/check_functions.dart#newcode689 tests/compiler/dart2js/equivalence/check_functions.dart:689: ...
3 years, 6 months ago (2017-05-30 22:41:15 UTC) #3
Johnni Winther
PTAL at the last patch https://codereview.chromium.org/2913713004/diff/1/tests/compiler/dart2js/equivalence/check_functions.dart File tests/compiler/dart2js/equivalence/check_functions.dart (right): https://codereview.chromium.org/2913713004/diff/1/tests/compiler/dart2js/equivalence/check_functions.dart#newcode675 tests/compiler/dart2js/equivalence/check_functions.dart:675: worldBuilder1.classUsageForTesting, On 2017/05/30 22:41:15, ...
3 years, 6 months ago (2017-05-31 10:46:38 UTC) #4
Johnni Winther
Committed patchset #2 (id:20001) manually as b97d158b9a729e3ade92004258f5bd8b5b0f2e9c (presubmit successful).
3 years, 6 months ago (2017-05-31 10:57:27 UTC) #6
Siggi Cherem (dart-lang)
3 years, 6 months ago (2017-05-31 15:54:41 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698