Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

Issue 2913693003: Replace deprecated base::NonThreadSafe in content/renderer/media/webrtc in favor of SequenceChecker. (Closed)
Patch Set: move media_stream_remote_video_source.cc to https://codereview.chromium.org/2909103002/ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/webrtc/peer_connection_dependency_factory.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/webrtc/peer_connection_dependency_factory.cc
diff --git a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
index dfb40366c5b47e9c77652d9974d2345605f10dbf..963de652a3970586c0825713f2d86e0fcd5f49c5 100644
--- a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
+++ b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
@@ -114,6 +114,7 @@ PeerConnectionDependencyFactory::PeerConnectionDependencyFactory(
}
PeerConnectionDependencyFactory::~PeerConnectionDependencyFactory() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
DVLOG(1) << "~PeerConnectionDependencyFactory()";
DCHECK(!pc_factory_);
}
@@ -443,7 +444,7 @@ PeerConnectionDependencyFactory::CreateIceCandidate(
WebRtcAudioDeviceImpl*
PeerConnectionDependencyFactory::GetWebRtcAudioDevice() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
EnsureWebRtcAudioDeviceImpl();
return audio_device_.get();
}
@@ -534,27 +535,27 @@ void PeerConnectionDependencyFactory::CleanupPeerConnectionFactory() {
}
void PeerConnectionDependencyFactory::EnsureInitialized() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
GetPcFactory();
}
scoped_refptr<base::SingleThreadTaskRunner>
PeerConnectionDependencyFactory::GetWebRtcWorkerThread() const {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
return chrome_worker_thread_.IsRunning() ? chrome_worker_thread_.task_runner()
: nullptr;
}
scoped_refptr<base::SingleThreadTaskRunner>
PeerConnectionDependencyFactory::GetWebRtcSignalingThread() const {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
return chrome_signaling_thread_.IsRunning()
? chrome_signaling_thread_.task_runner()
: nullptr;
}
void PeerConnectionDependencyFactory::EnsureWebRtcAudioDeviceImpl() {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
if (audio_device_.get())
return;
« no previous file with comments | « content/renderer/media/webrtc/peer_connection_dependency_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698