Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: content/renderer/media/webrtc/media_stream_track_metrics.cc

Issue 2913693003: Replace deprecated base::NonThreadSafe in content/renderer/media/webrtc in favor of SequenceChecker. (Closed)
Patch Set: move media_stream_remote_video_source.cc to https://codereview.chromium.org/2909103002/ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc/media_stream_track_metrics.cc
diff --git a/content/renderer/media/webrtc/media_stream_track_metrics.cc b/content/renderer/media/webrtc/media_stream_track_metrics.cc
index bf074edfbd63e8cdbf4dc52d1d1b59375a8a203d..a93a186360758c5c8e4f7af76b3937176e600802 100644
--- a/content/renderer/media/webrtc/media_stream_track_metrics.cc
+++ b/content/renderer/media/webrtc/media_stream_track_metrics.cc
@@ -269,6 +269,7 @@ MediaStreamTrackMetrics::MediaStreamTrackMetrics()
: ice_state_(webrtc::PeerConnectionInterface::kIceConnectionNew) {}
MediaStreamTrackMetrics::~MediaStreamTrackMetrics() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
for (const auto& observer : observers_) {
observer->SendLifetimeMessages(DISCONNECTED);
}
@@ -276,7 +277,7 @@ MediaStreamTrackMetrics::~MediaStreamTrackMetrics() {
void MediaStreamTrackMetrics::AddStream(StreamType type,
MediaStreamInterface* stream) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
observers_.push_back(
base::MakeUnique<MediaStreamTrackMetricsObserver>(type, stream, this));
SendLifeTimeMessageDependingOnIceState(observers_.back().get());
@@ -284,7 +285,7 @@ void MediaStreamTrackMetrics::AddStream(StreamType type,
void MediaStreamTrackMetrics::RemoveStream(StreamType type,
MediaStreamInterface* stream) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
auto it = std::find_if(observers_.begin(), observers_.end(),
ObserverFinder(type, stream));
if (it == observers_.end()) {
@@ -298,7 +299,7 @@ void MediaStreamTrackMetrics::RemoveStream(StreamType type,
void MediaStreamTrackMetrics::IceConnectionChange(
PeerConnectionInterface::IceConnectionState new_state) {
- DCHECK(CalledOnValidThread());
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
ice_state_ = new_state;
for (const auto& observer : observers_) {
SendLifeTimeMessageDependingOnIceState(observer.get());

Powered by Google App Engine
This is Rietveld 408576698