Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2444)

Unified Diff: chrome/browser/devtools/device/android_device_manager.cc

Issue 2913693002: Replace deprecated base::NonThreadSafe in chrome/browser/devtools in favor of SequenceChecker. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/device/android_device_manager.cc
diff --git a/chrome/browser/devtools/device/android_device_manager.cc b/chrome/browser/devtools/device/android_device_manager.cc
index 86901ff0007235e2dcf301d9230be35258899351..733bf154f41c0934616b81d037d0d0938cd37ba4 100644
--- a/chrome/browser/devtools/device/android_device_manager.cc
+++ b/chrome/browser/devtools/device/android_device_manager.cc
@@ -457,6 +457,7 @@ AndroidDeviceManager::Device::Device(
}
AndroidDeviceManager::Device::~Device() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
provider_->AddRef();
DeviceProvider* raw_ptr = provider_.get();
provider_ = nullptr;
@@ -541,6 +542,7 @@ AndroidDeviceManager::AndroidDeviceManager()
}
AndroidDeviceManager::~AndroidDeviceManager() {
+ DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
SetDeviceProviders(DeviceProviders());
}
« no previous file with comments | « chrome/browser/devtools/device/android_device_manager.h ('k') | chrome/browser/devtools/device/port_forwarding_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698