chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java - Issue 2913633002: [vr] Clicking on the security icon should prompt the user to bail out of VR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Issue 2913633002: [vr] Clicking on the security icon should prompt the user to bail out of VR (Closed)

Patch Set: added tests + cjgrant's comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('k') | chrome/app/generated_resources.grd » ('j') | chrome/browser/android/vr_shell/color_scheme.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

index 9ed4e760e1319239f2763bcc777abbe444553b26..847bd7ee222e1a6e17a5474a03c5a288d3d03d5a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

@@ -356,6 +356,13 @@ public class VrShellImpl

mDelegate.showDoffAndExitVr();

}

+ // Called because showing PageInfo isn't supported in VR. This happens when the user clicks on

+ // the security icon in the URL bar.

+ @CalledByNative

+ public void onUnhandledPageInfo() {

+ mDelegate.onUnhandledPageInfo();

+ }

// Exits CCT, returning to the app that opened it.

@CalledByNative

public void exitCct() {