Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/browser/android/vr_shell/color_scheme.h

Issue 2913633002: [vr] Clicking on the security icon should prompt the user to bail out of VR (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/color_scheme.h
diff --git a/chrome/browser/android/vr_shell/color_scheme.h b/chrome/browser/android/vr_shell/color_scheme.h
index 9f14c5ac2959919a06a9eeba054759a00f44bc31..103c9fa59f27fd386a6115dfae09b2517262f07c 100644
--- a/chrome/browser/android/vr_shell/color_scheme.h
+++ b/chrome/browser/android/vr_shell/color_scheme.h
@@ -31,6 +31,14 @@ struct ColorScheme {
SkColor emphasized;
SkColor deemphasized;
+ // The colors used for text and buttons on prompts.
cjgrant 2017/06/02 04:16:35 So these are different than the URL bar's backgrou
ymalik 2017/06/02 21:14:31 Yeah, Josh has them here: https://docs.google.com/
+ SkColor prompt_text;
amp 2017/06/02 20:37:01 Nit: The other values use 'foreground' instead of
ymalik 2017/06/04 04:08:56 Done. Though personally I found foreground weird a
+ SkColor primary_button_background;
+ SkColor secondary_button_background;
+ SkColor primary_button_text;
+ SkColor secondary_button_text;
+ SkColor button_background_hover;
amp 2017/06/02 20:37:01 do we need a button_background_down as well? and
ymalik 2017/06/04 04:08:56 Yes totally, latest patch adds that.
+
// This is the background color. To be used behind text in the foreground
// color. The related hover and down colors are to be used for buttons.
SkColor background;

Powered by Google App Engine
This is Rietveld 408576698