Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4056)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java

Issue 2913633002: [vr] Clicking on the security icon should prompt the user to bail out of VR (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
index 24a005e9f8ccdaf1eb303accc3bbf8215f205846..12efeff29cc21b6a62e1f55a9646537eb80b06c9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
@@ -90,11 +90,12 @@ import java.util.List;
*/
public class PageInfoPopup implements OnClickListener {
@Retention(RetentionPolicy.SOURCE)
- @IntDef({OPENED_FROM_MENU, OPENED_FROM_TOOLBAR})
+ @IntDef({OPENED_FROM_MENU, OPENED_FROM_TOOLBAR, OPENED_FROM_VR})
private @interface OpenedFromSource {}
public static final int OPENED_FROM_MENU = 1;
public static final int OPENED_FROM_TOOLBAR = 2;
+ public static final int OPENED_FROM_VR = 3;
/**
* An entry in the settings dropdown for a given permission. There are two options for each
@@ -997,6 +998,8 @@ public class PageInfoPopup implements OnClickListener {
RecordUserAction.record("MobileWebsiteSettingsOpenedFromMenu");
} else if (source == OPENED_FROM_TOOLBAR) {
RecordUserAction.record("MobileWebsiteSettingsOpenedFromToolbar");
+ } else if (source == OPENED_FROM_VR) {
+ RecordUserAction.record("MobileWebsiteSettingsOpenedFromVR");
} else {
assert false : "Invalid source passed";
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698