 Chromium Code Reviews
 Chromium Code Reviews Issue 2913593002:
  Implementation of translation event logging.  (Closed)
    
  
    Issue 2913593002:
  Implementation of translation event logging.  (Closed) 
  | Index: components/translate/core/browser/translate_client.h | 
| diff --git a/components/translate/core/browser/translate_client.h b/components/translate/core/browser/translate_client.h | 
| index 1225a27e852910e0c346317804eae46af17626bf..c5d451afa95f46d3562e447e019d0ab319c581d9 100644 | 
| --- a/components/translate/core/browser/translate_client.h | 
| +++ b/components/translate/core/browser/translate_client.h | 
| @@ -20,6 +20,10 @@ namespace infobars { | 
| class InfoBar; | 
| } | 
| +namespace metrics { | 
| +class TranslateEventProto; | 
| +} // namespace metrics | 
| + | 
| namespace translate { | 
| class TranslateAcceptLanguages; | 
| @@ -50,6 +54,10 @@ class TranslateClient { | 
| // Returns the resource ID of the icon to be shown for the Translate infobars. | 
| virtual int GetInfobarIconID() const = 0; | 
| + // Record translate event. | 
| + // This is for gaia-keyed logging. | 
| 
amoylan
2017/05/30 03:10:56
Is 'gaia' the right terminology to use in the cont
 
renjieliu1
2017/05/30 03:33:24
thanks for pointing out this!
 | 
| + virtual void RecordTranslateEvent(const metrics::TranslateEventProto&) = 0; | 
| 
amoylan
2017/05/30 03:10:56
Include name of the parameter to RecordTranslateEv
 
renjieliu1
2017/05/30 03:33:24
Done.
 | 
| + | 
| #if !defined(USE_AURA) | 
| // Returns a translate infobar that owns |delegate|. | 
| virtual std::unique_ptr<infobars::InfoBar> CreateInfoBar( |