Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/web_view/internal/translate/web_view_translate_client.mm

Issue 2913593002: Implementation of translation event logging. (Closed)
Patch Set: updates Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ios/chrome/browser/translate/chrome_ios_translate_client.mm ('K') | « ios/web_view/internal/translate/web_view_translate_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/internal/translate/web_view_translate_client.mm
diff --git a/ios/web_view/internal/translate/web_view_translate_client.mm b/ios/web_view/internal/translate/web_view_translate_client.mm
index ddc9bed2305bb80029b705665fcf669dcd387ae1..b113f75fdf75c2d85c36f12f4c49194d25d30bc2 100644
--- a/ios/web_view/internal/translate/web_view_translate_client.mm
+++ b/ios/web_view/internal/translate/web_view_translate_client.mm
@@ -112,6 +112,11 @@ int WebViewTranslateClient::GetInfobarIconID() const {
return 0;
}
+void WebViewTranslateClient::RecordTranslateEvent(
+ const metrics::TranslateEventProto&) {
+ // TODO(renjieliu): Implementing gaia-keyed logging.
Eugene But (OOO till 7-30) 2017/06/12 01:50:00 ditto
renjieliu1 2017/06/13 00:04:59 Done.
+}
+
bool WebViewTranslateClient::IsTranslatableURL(const GURL& url) {
return !url.is_empty() && !url.SchemeIs(url::kFtpScheme);
}
« ios/chrome/browser/translate/chrome_ios_translate_client.mm ('K') | « ios/web_view/internal/translate/web_view_translate_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698