Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: ios/web_view/internal/translate/web_view_translate_client.mm

Issue 2913593002: Implementation of translation event logging. (Closed)
Patch Set: fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/internal/translate/web_view_translate_client.mm
diff --git a/ios/web_view/internal/translate/web_view_translate_client.mm b/ios/web_view/internal/translate/web_view_translate_client.mm
index 20af563706b74532e3d5ca8c4c7adb1d6d251080..e98f3198c2bdef58f073cacaf8f06d25e070bb7c 100644
--- a/ios/web_view/internal/translate/web_view_translate_client.mm
+++ b/ios/web_view/internal/translate/web_view_translate_client.mm
@@ -108,6 +108,11 @@ int WebViewTranslateClient::GetInfobarIconID() const {
return 0;
}
+void WebViewTranslateClient::RecordTranslateEvent(
+ const metrics::TranslateEventProto&) {
+ // TODO(renjieliu): Implementing gaia-keyed logging.
+}
+
bool WebViewTranslateClient::IsTranslatableURL(const GURL& url) {
return !url.is_empty() && !url.SchemeIs(url::kFtpScheme);
}

Powered by Google App Engine
This is Rietveld 408576698