Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm

Issue 2913573002: Updates language model on iOS. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
diff --git a/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm b/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
index 1600961322b0c4fb083f462fab1c96bb09539524..b4eb8e04656a39318d1972cc1b038f7fdd6c646a 100644
--- a/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
+++ b/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
@@ -24,6 +24,7 @@
#include "components/prefs/pref_service.h"
#include "components/search_engines/template_url_service.h"
#include "components/sessions/core/tab_restore_service.h"
+#include "components/translate/core/browser/language_model.h"
#include "ios/chrome/browser/application_context.h"
#include "ios/chrome/browser/autofill/personal_data_manager_factory.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
@@ -33,6 +34,7 @@
#include "ios/chrome/browser/passwords/ios_chrome_password_store_factory.h"
#include "ios/chrome/browser/search_engines/template_url_service_factory.h"
#include "ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.h"
+#include "ios/chrome/browser/translate/language_model_factory.h"
#include "ios/chrome/browser/web_data_service_factory.h"
#include "ios/net/http_cache_helper.h"
#include "ios/public/provider/chrome/browser/chrome_browser_provider.h"
@@ -350,6 +352,13 @@ void IOSChromeBrowsingDataRemover::RemoveImpl(int remove_mask) {
UMA_HISTOGRAM_ENUMERATION(
"History.ClearBrowsingData.UserDeletedCookieOrCache", choice,
MAX_CHOICE_VALUE);
+
+ // Remove language model history.
martis 2017/06/01 06:49:21 I believe the language model should only be cleare
ramyasharma 2017/06/02 07:20:24 Thanks, good catch.
+ translate::LanguageModel* language_model =
+ translate::LanguageModelFactory::GetForBrowserState(browser_state_);
+ if (language_model) {
+ language_model->ClearHistory(delete_begin_, delete_end_);
+ }
}
void IOSChromeBrowsingDataRemover::AddObserver(Observer* observer) {

Powered by Google App Engine
This is Rietveld 408576698