js_checker.py: Replace custom WrapperTypeCheck with ESLint's no-new-wrappers.

tools/web_dev_style/PRESUBMIT.py

Index: tools/web_dev_style/PRESUBMIT.py
diff --git a/tools/web_dev_style/PRESUBMIT.py b/tools/web_dev_style/PRESUBMIT.py
index d808f851dd1c9f89cf2989b77a4f1c07764f9c95..c2d69e3d377224c8c49650efc7c54c5eb153f4dd 100644
--- a/tools/web_dev_style/PRESUBMIT.py
+++ b/tools/web_dev_style/PRESUBMIT.py
@@ -27,6 +27,7 @@ def _CommonChecks(input_api, output_api):
 
   if utils_changed or any(f for f in files if f.startswith('js_checker')):
     tests.append(path.join(cwd, 'js_checker_test.py'))
+    tests.append(path.join(cwd, 'js_checker_eslint_test.py'))

[dpapad, 2017/05/31 22:30:20]

I am planning to detect .eslintrc.js changes in a  follow up CL.

[Dan Beam, 2017/05/31 22:54:33]

Acknowledged.

[Dan Beam, 2017/05/31 22:54:33]

nit:

tests += [path.join(cwd, 'js_checker_%stest.py' % e) for e in '', 'eslint_']

[dpapad, 2017/05/31 22:58:10]

Even though I acknowledge that this is shorter and more python-ic way of doing
things, prefer not to do this, because it reduces grep-ability, for example
grepping the code for "js_checker_test.py" will return no results.

 
   if utils_changed or any(f for f in files if f.startswith('resource_checker')):
     tests.append(path.join(cwd, 'resource_checker_test.py'))