js_checker.py: Replace custom WrapperTypeCheck with ESLint's no-new-wrappers.

tools/web_dev_style/js_checker_test.py

 #!/usr/bin/env python
 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import js_checker
 from os import path as os_path
 import re
 from sys import path as sys_path
 import test_util
@@ skipping 249 matching lines @@
 
   def testPolymerLocalIdPasses(self):
     lines = [
         "this.$.id",
         "this.$.localId",
         "this.$['fancy-id']",
     ]
     for line in lines:
       self.ShouldPassPolymerLocalIdCheck(line)
 
-  def ShouldFailWrapperTypeCheck(self, line):

[Dan Beam, 2017/05/30 16:16:20]

can we leave these?  i know there's likely tests for ESLint but if were ever to
change the implementation it might be hard to know there were ever tests like
this

[dpapad, 2017/05/31 22:30:20]

Added equivalent smoke tests in js_checker_eslint_test.py.

-    """Checks that the use of wrapper types (i.e. new Number(), @type {Number})
-       is a style error.
-    """
-    error = self.checker.WrapperTypeCheck(1, line)
-    self.assertNotEqual('', error,
-        msg='Should be flagged as style error: ' + line)
-    highlight = test_util.GetHighlight(line, error)
-    self.assertTrue(highlight in ('Boolean', 'Number', 'String'))
-
-  def ShouldPassWrapperTypeCheck(self, line):
-    """Checks that the wrapper type checker doesn't flag |line| as a style
-       error.
-    """
-    self.assertEqual('', self.checker.WrapperTypeCheck(1, line),
-        msg='Should not be flagged as style error: ' + line)
-
-  def testWrapperTypePasses(self):
-    lines = [
-        "/** @param {!ComplexType} */",
-        "  * @type {Object}",
-        "   * @param {Function=} opt_callback",
-        "    * @param {} num Number of things to add to {blah}.",
-        "   *  @return {!print_preview.PageNumberSet}",
-        " /* @returns {Number} */",  # Should be /** @return {Number} */
-        "* @param {!LocalStrings}"
-        " Your type of Boolean is false!",
-        "  Then I parameterized a Number from my friend!",
-        "   A String of Pearls",
-        "    types.params.aBoolean.typeString(someNumber)",
-    ]
-    for line in lines:
-      self.ShouldPassWrapperTypeCheck(line)
-
-  def testWrapperTypeFails(self):
-    lines = [
-        "  /**@type {String}*/(string)",
-        "   * @param{Number=} opt_blah A number",
-        "/** @private @return {!Boolean} */",
-        " * @param {number|String}",
-    ]
-    for line in lines:
-      self.ShouldFailWrapperTypeCheck(line)
-
   def ShouldFailVarNameCheck(self, line):
     """Checks that var unix_hacker, $dollar are style errors."""
     error = self.checker.VarNameCheck(1, line)
     self.assertNotEqual('', error,
         msg='Should be flagged as style error: ' + line)
     highlight = test_util.GetHighlight(line, error)
     self.assertFalse('var ' in highlight);
 
   def ShouldPassVarNameCheck(self, line):
     """Checks that variableNamesLikeThis aren't style errors."""
@@ skipping 24 matching lines @@
         " var SCARE_SMALL_CHILDREN = [",         # TODO(dbeam): add @const in
                                                  # front of all these vars like
         "/** @const */ CONST_VAR = 1;",          # this line has (<--).
     ]
     for line in lines:
       self.ShouldPassVarNameCheck(line)
 
 
 if __name__ == '__main__':
   unittest.main()