Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: trunk/src/content/renderer/p2p/ipc_network_manager.cc

Issue 291343010: Revert 272379 "Revert 272371 "Add UMA Counts for number of IPv4 ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/content/renderer/p2p/ipc_network_manager.cc
===================================================================
--- trunk/src/content/renderer/p2p/ipc_network_manager.cc (revision 272552)
+++ trunk/src/content/renderer/p2p/ipc_network_manager.cc (working copy)
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/command_line.h"
+#include "base/metrics/histogram.h"
#include "base/sys_byteorder.h"
#include "content/public/common/content_switches.h"
#include "net/base/net_util.h"
@@ -75,6 +76,8 @@
// talk_base::Network uses these prefix_length to compare network
// interfaces discovered.
std::vector<talk_base::Network*> networks;
+ int ipv4_interfaces = 0;
+ int ipv6_interfaces = 0;
for (net::NetworkInterfaceList::const_iterator it = list.begin();
it != list.end(); it++) {
if (it->address.size() == net::kIPv4AddressSize) {
@@ -86,6 +89,7 @@
ConvertConnectionTypeToAdapterType(it->type));
network->AddIP(talk_base::IPAddress(address));
networks.push_back(network);
+ ++ipv4_interfaces;
} else if (it->address.size() == net::kIPv6AddressSize) {
in6_addr address;
memcpy(&address, &it->address[0], sizeof(in6_addr));
@@ -96,10 +100,21 @@
ConvertConnectionTypeToAdapterType(it->type));
network->AddIP(ip6_addr);
networks.push_back(network);
+ ++ipv6_interfaces;
}
}
}
+ if (ipv4_interfaces > 0) {
+ UMA_HISTOGRAM_COUNTS_100("WebRTC.PeerConnection.IPv4Interfaces",
+ ipv4_interfaces);
+ }
+
+ if (ipv6_interfaces > 0) {
+ UMA_HISTOGRAM_COUNTS_100("WebRTC.PeerConnection.IPv6Interfaces",
+ ipv6_interfaces);
+ }
+
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kAllowLoopbackInPeerConnection)) {
std::string name_v4("loopback_ipv4");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698