Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: BUILD.gn

Issue 291343002: Enable more targets in the Android GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | crypto/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index a39045e3fd6d7f0049141ea3141b7a92a1249559..2752b7434c40202f2214d3061a4ea3fc1e1c4a62 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -50,7 +50,7 @@ group("root") {
"//third_party/libwebm",
"//third_party/libwebp",
"//third_party/ots",
- "//third_party/protobuf:protobuf_lite",
+ "//third_party/protobuf:protobuf_lite",
"//third_party/qcms",
"//third_party/re2",
"//third_party/smhasher:cityhash",
@@ -82,23 +82,17 @@ group("root") {
if (is_android) {
deps -= [
- "//components/os_crypt",
- "//crypto",
- "//gpu/command_buffer/client", # Needs Skia.
+ "//gpu/command_buffer/client", # Needs some JNI stuff:
"//gpu/command_buffer/service",
"//net",
"//third_party/libusb",
- # Should work, but staging this landing for Android separately.
- "//third_party/protobuf:protobuf_lite",
#"//third_party/WebKit/Source/platform",
"//third_party/WebKit/Source/wtf", # TODO(brettw) re-enable for Android.
"//tools/gn",
- # This UI stuff is blocked on Skia.
- "//ui/accessibility",
+ # ui_base doesn't work yet, and neither do things that depend on it.
tfarina 2014/05/21 20:57:33 what do you mean by does not work yet? I guess you
brettw 2014/05/21 20:59:30 I just need to fix some conditions in ui_base, no
"//ui/base:ui_base",
"//ui/events",
- "//ui/gfx",
"//ui/surface",
]
}
« no previous file with comments | « no previous file | crypto/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698