Issue 291343002: Enable more targets in the Android GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 291343002: Enable more targets in the Android GN build. (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
cjhopman

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable more targets in the Android GN build. This enables some already-working targets and adds a missing cpufeatures dep to crypto to make it compile. I added a comment in the cpufeatures build file so I can find it more easily by grepping next time. R=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272362

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
M	BUILD.gn	View	1	2 chunks	+3 lines, -9 lines	0 comments	Download
M	crypto/BUILD.gn	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/gn/secondary/third_party/android_tools/BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tfarina

https://codereview.chromium.org/291343002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/291343002/diff/1/BUILD.gn#newcode93 BUILD.gn:93: # ui_base doesn't work yet, and neither do things ...

6 years, 7 months ago (2014-05-21 20:57:33 UTC) #3

brettw

6 years, 7 months ago (2014-05-21 20:59:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r272362.

Expand Messages | Collapse Messages