network_time: Remove NetworkTimeService

network_time: Remove NetworkTimeService

Use the local state instead of a pref belonging to a Profile.
Save the time mapping when the network time is updated, load the saved time in the ctor.
Delay initialization of BrowserProcess::network_time_tracker_ to access the local state.

BUG=371470
TEST=git cl try

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273784

[hashimoto, 2014-05-26 02:21:49]

Please review.
The new code saves the network time to the local state every time it gets
updated.
Does this sound OK to you? (perhaps it's too frequent?)

[hashimoto, 2014-05-26 02:22:16]

cc: blundell

[haitaol1, 2014-05-27 23:09:30]

Please also seek approval for changes to browser_process_impl.cc, etc.

https://codereview.chromium.org/291333009/diff/20001/chrome/browser/network_t...
File chrome/browser/network_time/network_time_tracker.cc (right):

https://codereview.chromium.org/291333009/diff/20001/chrome/browser/network_t...
chrome/browser/network_time/network_time_tracker.cc:44:
switches::kEnableNetworkTime)) {
This switch is probably not needed. You can turn on network time always.

https://codereview.chromium.org/291333009/diff/20001/chrome/browser/network_t...
chrome/browser/network_time/network_time_tracker.cc:103: if
(CommandLine::ForCurrentProcess()->HasSwitch(
same here.

[hashimoto, 2014-05-28 11:25:52]

https://codereview.chromium.org/291333009/diff/20001/chrome/browser/network_t...
File chrome/browser/network_time/network_time_tracker.cc (right):

https://codereview.chromium.org/291333009/diff/20001/chrome/browser/network_t...
chrome/browser/network_time/network_time_tracker.cc:44:
switches::kEnableNetworkTime)) {
On 2014/05/27 23:09:31, haitaol1 wrote:
> This switch is probably not needed. You can turn on network time always.

Done.

https://codereview.chromium.org/291333009/diff/20001/chrome/browser/network_t...
chrome/browser/network_time/network_time_tracker.cc:103: if
(CommandLine::ForCurrentProcess()->HasSwitch(
On 2014/05/27 23:09:31, haitaol1 wrote:
> same here.

Done.

[haitaol1, 2014-05-28 20:57:27]

code LGTM, please fix tests

[hashimoto, 2014-05-29 04:31:30]

On 2014/05/28 20:57:27, haitaol1 wrote:
> code LGTM, please fix tests

Oops, sorry, I should have run NetworkTimeTrackerTest before uploading.
Done.

[hashimoto, 2014-05-29 04:32:56]

sky@, could you review the following files?
    chrome/browser/browser_process_impl.cc
    chrome/browser/prefs/browser_prefs.cc
    chrome/test/base/testing_browser_process.cc
In the new code, BrowserProcessImpl creates NetworkTimeTracker when it is
requested for the first time.
This is needed as NetworkTimeTracker depends on the local state.

[sky, 2014-05-29 15:00:46]

LGTM

[hashimoto, 2014-05-30 01:10:34]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-05-30 01:11:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/291333009/80001

[commit-bot: I haz the power, 2014-05-30 10:17:06]

Change committed as 273784