Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 291333007: Remove tools/safely-roll-blink now that tools/safely-roll-deps is stable. (Closed)

Created:
6 years, 7 months ago by blink-deps-roller
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove tools/safely-roll-blink now that tools/safely-roll-deps is stable. "tools/safely-roll-deps /src blink" is the replacemnt syntax. No need to keep dead code around. BUG=242461 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -161 lines) Patch
D tools/safely-roll-deps.py View 1 chunk +0 lines, -161 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
eseidel
I uploaded this from the blink-deps-roller account mostly for testing, but we do want this ...
6 years, 7 months ago (2014-05-22 18:34:38 UTC) #1
borenet
LGTM but I don't count.
6 years, 7 months ago (2014-05-22 18:36:32 UTC) #2
M-A Ruel
On 2014/05/22 18:36:32, borenet wrote: > LGTM but I don't count. lgtm
6 years, 7 months ago (2014-05-22 18:49:22 UTC) #3
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 7 months ago (2014-05-22 18:50:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blink-deps-roller@chromium.org/291333007/1
6 years, 7 months ago (2014-05-22 18:53:35 UTC) #5
commit-bot: I haz the power
Change committed as 272347
6 years, 7 months ago (2014-05-22 22:22:07 UTC) #6
borenet
A revert of this CL has been created in https://codereview.chromium.org/294163012/ by borenet@google.com. The reason for ...
6 years, 7 months ago (2014-05-23 13:20:06 UTC) #7
M-A Ruel
On 2014/05/23 13:20:06, borenet wrote: > A revert of this CL has been created in ...
6 years, 7 months ago (2014-05-23 14:08:47 UTC) #8
borenet
On 2014/05/23 14:08:47, M-A Ruel wrote: > On 2014/05/23 13:20:06, borenet wrote: > > A ...
6 years, 7 months ago (2014-05-23 14:11:14 UTC) #9
eseidel
6 years, 7 months ago (2014-05-23 16:17:18 UTC) #10
Message was sent while issue was closed.
ha!  Sorry about that. :(

Powered by Google App Engine
This is Rietveld 408576698