Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: chrome/browser/ui/webui/help/help_utils_chromeos.cc

Issue 2913323003: Settings: Network: Merge Tether networks into Mobile subpage (Closed)
Patch Set: Fix browser_tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/help/help_utils_chromeos.h" 5 #include "chrome/browser/ui/webui/help/help_utils_chromeos.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 const std::string type = 56 const std::string type =
57 network->IsUsingMobileData() ? shill::kTypeCellular : network->type(); 57 network->IsUsingMobileData() ? shill::kTypeCellular : network->type();
58 if (chromeos::NetworkTypePattern::Ethernet().MatchesType(type)) 58 if (chromeos::NetworkTypePattern::Ethernet().MatchesType(type))
59 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_ETHERNET); 59 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_ETHERNET);
60 if (type == shill::kTypeWifi) 60 if (type == shill::kTypeWifi)
61 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_WIFI); 61 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_WIFI);
62 if (type == shill::kTypeWimax) 62 if (type == shill::kTypeWimax)
63 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_WIMAX); 63 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_WIMAX);
64 if (type == shill::kTypeBluetooth) 64 if (type == shill::kTypeBluetooth)
65 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_BLUETOOTH); 65 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_BLUETOOTH);
66 if (type == shill::kTypeCellular) 66 if (type == shill::kTypeCellular ||
67 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_CELLULAR); 67 chromeos::NetworkTypePattern::Tether().MatchesType(type)) {
68 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_MOBILE_DATA);
69 }
68 if (type == shill::kTypeVPN) 70 if (type == shill::kTypeVPN)
69 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_VPN); 71 return l10n_util::GetStringUTF16(IDS_NETWORK_TYPE_VPN);
70 NOTREACHED(); 72 NOTREACHED();
71 return base::string16(); 73 return base::string16();
72 } 74 }
73 75
74 } // namespace help_utils_chromeos 76 } // namespace help_utils_chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698