GRC: Hook up the frame-level CoordinationUnit

chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc

Index: chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
diff --git a/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc b/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
index cfa88b7309c048992a75f07789e094e8cff35c8b..f4a13bf4b8e07697021a6af9f882e7b9e264721a 100644
--- a/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
+++ b/chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.cc
@@ -4,6 +4,8 @@
 
 #include "chrome/browser/resource_coordinator/resource_coordinator_web_contents_observer.h"
 
+#include "content/public/browser/navigation_handle.h"
+#include "content/public/browser/render_frame_host.h"
 #include "content/public/common/service_manager_connection.h"
 #include "services/resource_coordinator/public/cpp/resource_coordinator_features.h"
 
@@ -35,3 +37,12 @@ void ResourceCoordinatorWebContentsObserver::WasHidden() {
   tab_resource_coordinator_->SendEvent(
       resource_coordinator::EventType::kOnWebContentsHidden);
 }
+
+void ResourceCoordinatorWebContentsObserver::ReadyToCommitNavigation(
+    content::NavigationHandle* navigation_handle) {
+  auto* frame_resource_coordinator =
+      navigation_handle->GetRenderFrameHost()->GetFrameResourceCoordinator();
+  tab_resource_coordinator_->AddChild(*frame_resource_coordinator);
+  frame_resource_coordinator->SendEvent(
+      resource_coordinator::EventType::kOnNavigationCommit);

[nasko, 2017/06/02 23:29:16]

The frame hasn't committed yet, so it seems premature to send a commit event
here. You are better off doing it in DidFinishNavigation and ensuring that it
did actually successful commit a document.

In addition, this fires on each navigation, even though the RenderFrameHost
stays the same, so you will be adding duplicate child nodes.

[oystein (OOO til 10th of July), 2017/06/05 20:02:39]

Changed to DidFinishNavigation w/ error checks and removed the
kOnNavigationCommit event since it's not being used yet regardless, the thing we
need right now is just the parent/child relationship. CoordinationUnit::AddChild
will return early if there's an existing parent/child relationship, so firing
this off multiple times for the same RenderFrameHost shouldn't be an issue.

+}