Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: chrome/browser/password_manager/password_manager_test_base.h

Issue 2913193002: Enable PasswordManagerBrowserTestBase.UsernameChanged (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/password_manager/password_manager_interactive_uitest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_manager_test_base.h
diff --git a/chrome/browser/password_manager/password_manager_test_base.h b/chrome/browser/password_manager/password_manager_test_base.h
index c7043bf4b7dced61b7838719ef69bf4540e5bbbb..288facf38d4c76a9b2282d42e9a10695749d1383 100644
--- a/chrome/browser/password_manager/password_manager_test_base.h
+++ b/chrome/browser/password_manager/password_manager_test_base.h
@@ -137,6 +137,10 @@ class PasswordManagerBrowserTestBase : public InProcessBrowserTest {
// waits until the "change" event is fired for the element. This also
// guarantees that once the real value matches the expected, the JavaScript
// event loop is spun to allow all other possible events to take place.
+ // WARNING:
+ // - the function waits only for the first "onchange" event.
+ // - "onchange" event is triggered by autofill. However, if user's typing is
+ // simulated then the event is triggered only when control looses focus.
void WaitForElementValue(const std::string& element_id,
const std::string& expected_value);
// Same as above except the element |element_id| is in iframe |iframe_id|
« no previous file with comments | « chrome/browser/password_manager/password_manager_interactive_uitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698