Remove font cache deletion code

chrome/browser/chrome_browser_main_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main_win.h"
 
 #include <shellapi.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <windows.h>
@@ skipping 335 matching lines @@
 void ChromeBrowserMainPartsWin::ShowMissingLocaleMessageBox() {
   ui::MessageBox(NULL,
                  base::ASCIIToUTF16(chrome_browser::kMissingLocaleDataMessage),
                  base::ASCIIToUTF16(chrome_browser::kMissingLocaleDataTitle),
                  MB_OK | MB_ICONERROR | MB_TOPMOST);
 }
 
 void ChromeBrowserMainPartsWin::PostProfileInit() {
   ChromeBrowserMainParts::PostProfileInit();
 
   // TODO(kulshin): remove this cleanup code in 2017. http://crbug.com/603718

[Nico, 2017/05/31 14:44:12]

Given that it's 2017 now, can we just delete this whole call?

[gab, 2017/05/31 14:55:01]

Yes we can, this was cleanup added for a year in April 2016.

[ftirelo, 2017/05/31 15:33:56]

Done.

[ftirelo, 2017/05/31 15:33:56]

Done.

   // Attempt to delete the font cache and ignore any errors.
   base::FilePath path(
       profile()->GetPath().AppendASCII("ChromeDWriteFontCache"));
   content::BrowserThread::PostAfterStartupTask(
-      FROM_HERE, content::BrowserThread::GetTaskRunnerForThread(
-                     content::BrowserThread::FILE),

[gab, 2017/05/31 14:55:01]

Surprised that using the FILE thread would have made this flaky.

[ftirelo, 2017/05/31 15:33:56]

Acknowledged.

+      FROM_HERE, profile()->GetIOTaskRunner(),
       base::Bind(base::IgnoreResult(&base::DeleteFile), path, false));
 
   // Create the module database and hook up the in-process module watcher. This
   // needs to be done before any child processes are initialized as the
   // ModuleDatabase is an endpoint for IPC from child processes.
   if (base::FeatureList::IsEnabled(features::kModuleDatabase))
     SetupModuleDatabase(&module_watcher_);
 }
 
 void ChromeBrowserMainPartsWin::PostBrowserStart() {
@@ skipping 192 matching lines @@
   if (resource_id)
     return l10n_util::GetStringUTF16(resource_id);
   return base::string16();
 }
 
 // static
 void ChromeBrowserMainPartsWin::SetupInstallerUtilStrings() {
   CR_DEFINE_STATIC_LOCAL(TranslationDelegate, delegate, ());
   installer::SetTranslationDelegate(&delegate);
 }