Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1709)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/media/media_factory.cc

Issue 2913153004: Fix MediaRemoting MediaObserver (Closed)
Patch Set: remove debugging Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_factory.cc
diff --git a/content/renderer/media/media_factory.cc b/content/renderer/media/media_factory.cc
index efeba89bc79c54e629737d969dab9764b1e6a27b..095ed07cf793c95c7552d1b0356b9dc1c076cc66 100644
--- a/content/renderer/media/media_factory.cc
+++ b/content/renderer/media/media_factory.cc
@@ -349,8 +349,7 @@ MediaFactory::CreateRendererFactorySelector(
std::unique_ptr<RemotingController> remoting_controller(
new RemotingController(new media::remoting::SharedSession(
std::move(remoting_source_request), std::move(remoter))));
- base::WeakPtr<media::MediaObserver> media_observer =
- remoting_controller->GetWeakPtr();
+ *out_media_observer = remoting_controller->GetWeakPtr();
miu 2017/06/05 20:02:03 Hmm...Surprised the old code didn't generate a com
auto courier_factory =
base::MakeUnique<media::remoting::CourierRendererFactory>(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698