Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: ash/system/network/network_icon.cc

Issue 2913103002: Add Tether to Mobile NetworkTypePattern. (Closed)
Patch Set: khorimoto@ and stevenjb@ comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/network/network_icon.cc
diff --git a/ash/system/network/network_icon.cc b/ash/system/network/network_icon.cc
index 1174c006d687a4ae97b67238cf40d959791da5e5..961ae7d30dede485031326fd8643ef14c57ae312 100644
--- a/ash/system/network/network_icon.cc
+++ b/ash/system/network/network_icon.cc
@@ -878,13 +878,15 @@ base::string16 GetLabelForNetwork(const chromeos::NetworkState* network,
}
}
-int GetCellularUninitializedMsg() {
+int GetMobileUninitializedMsg() {
static base::Time s_uninitialized_state_time;
static int s_uninitialized_msg(0);
NetworkStateHandler* handler = NetworkHandler::Get()->network_state_handler();
if (handler->GetTechnologyState(NetworkTypePattern::Mobile()) ==
NetworkStateHandler::TECHNOLOGY_UNINITIALIZED) {
+ // TODO (lesliewatkins): Add a more descriptive message (e.g. "Enable
+ // Bluetooth" for Tether technology type.
Kyle Horimoto 2017/06/05 17:43:30 Close the open parenthesis.
lesliewatkins 2017/06/05 18:16:53 Done.
Kyle Horimoto 2017/06/05 18:26:00 You closed it in the wrong spot. It should be clos
s_uninitialized_msg = IDS_ASH_STATUS_TRAY_INITIALIZING_CELLULAR;
s_uninitialized_state_time = base::Time::Now();
return s_uninitialized_msg;
@@ -951,7 +953,7 @@ void GetDefaultNetworkImageAndLabel(IconType icon_type,
}
if (!network) {
// If no connecting network, check for cellular initializing.
Kyle Horimoto 2017/06/05 17:43:30 mobile
lesliewatkins 2017/06/05 18:16:53 Done.
- int uninitialized_msg = GetCellularUninitializedMsg();
+ int uninitialized_msg = GetMobileUninitializedMsg();
if (uninitialized_msg != 0) {
*image = GetConnectingImage(icon_type, shill::kTypeCellular);
if (label)

Powered by Google App Engine
This is Rietveld 408576698