Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Unified Diff: chromeos/network/network_state_handler_unittest.cc

Issue 2913103002: Add Tether to Mobile NetworkTypePattern. (Closed)
Patch Set: fixed usage of Cellular vs Mobile in some files Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_state_handler_unittest.cc
diff --git a/chromeos/network/network_state_handler_unittest.cc b/chromeos/network/network_state_handler_unittest.cc
index ee62d71b63011c6f02ea56e74be4efb4d4b56869..e7201cb972aca54ab9b2cfe38e4d6f3b5a292ac1 100644
--- a/chromeos/network/network_state_handler_unittest.cc
+++ b/chromeos/network/network_state_handler_unittest.cc
@@ -337,9 +337,10 @@ TEST_F(NetworkStateHandlerTest, NetworkStateHandlerStub) {
EXPECT_EQ(kShillManagerClientStubDefaultWifi,
network_state_handler_->ConnectedNetworkByType(
NetworkTypePattern::WiFi())->path());
- EXPECT_EQ(kShillManagerClientStubCellular,
- network_state_handler_->FirstNetworkByType(
- NetworkTypePattern::Mobile())->path());
+ EXPECT_EQ(
+ kShillManagerClientStubCellular,
+ network_state_handler_->FirstNetworkByType(NetworkTypePattern::Cellular())
+ ->path());
EXPECT_EQ(
Kyle Horimoto 2017/06/01 22:12:23 Isn't this the same exact assertion as above?
stevenjb 2017/06/01 22:29:47 It is. I'm not sure why this changed, Mobile() sho
lesliewatkins 2017/06/02 21:31:17 Done. Oops!
kShillManagerClientStubCellular,
network_state_handler_->FirstNetworkByType(NetworkTypePattern::Cellular())

Powered by Google App Engine
This is Rietveld 408576698