Add Tether to Mobile NetworkTypePattern.

ash/system/network/network_icon.cc

Index: ash/system/network/network_icon.cc
diff --git a/ash/system/network/network_icon.cc b/ash/system/network/network_icon.cc
index 1174c006d687a4ae97b67238cf40d959791da5e5..047cd2212b99898e07a09736d21a272bbcd91419 100644
--- a/ash/system/network/network_icon.cc
+++ b/ash/system/network/network_icon.cc
@@ -883,12 +883,12 @@ int GetCellularUninitializedMsg() {
   static int s_uninitialized_msg(0);
 
   NetworkStateHandler* handler = NetworkHandler::Get()->network_state_handler();
-  if (handler->GetTechnologyState(NetworkTypePattern::Mobile()) ==
+  if (handler->GetTechnologyState(NetworkTypePattern::Cellular()) ==

[Kyle Horimoto, 2017/06/01 22:12:23]

Do we still want this behavior for WiMAX?

[stevenjb, 2017/06/01 22:29:47]

Actually yes, this should still be Mobile(). This is called from
network_list.cc, and even though we say Cellular, we basically treat WiMAX the
same. We should probably s/Cellular/Mobile throughout this function.

Tether state will only be returned if Cellular and WiMAX are unavailable. We can
decide to either show 'Initializing...' when Tether is uninitialized, show
something else (e.g. 'Enable bluetooth...'), or exclude Tether here.

[lesliewatkins, 2017/06/02 21:31:17]

Done.

Switched it back to Mobile, changed the name of the function, and added a TODO
to create a more descriptive message if Tether is uninitialized.

       NetworkStateHandler::TECHNOLOGY_UNINITIALIZED) {
     s_uninitialized_msg = IDS_ASH_STATUS_TRAY_INITIALIZING_CELLULAR;
     s_uninitialized_state_time = base::Time::Now();
     return s_uninitialized_msg;
-  } else if (handler->GetScanningByType(NetworkTypePattern::Mobile())) {
+  } else if (handler->GetScanningByType(NetworkTypePattern::Cellular())) {

[stevenjb, 2017/06/01 22:29:47]

This seems like we want to include Tether; if it sets scanning() then we
probably want to show that state and if it doesn't then it doesn't matter.

[lesliewatkins, 2017/06/02 21:31:17]

Done.

     s_uninitialized_msg = IDS_ASH_STATUS_TRAY_MOBILE_SCANNING;
     s_uninitialized_state_time = base::Time::Now();
     return s_uninitialized_msg;