Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2913043002: fix fasta scanner adapter lineStarts (Closed)

Created:
3 years, 6 months ago by danrubel
Modified:
3 years, 6 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M pkg/analyzer/lib/src/dart/scanner/scanner.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/front_end/test/scanner_fasta_test.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 6 months ago (2017-05-30 19:12:38 UTC) #2
Paul Berry
lgtm
3 years, 6 months ago (2017-05-30 20:40:37 UTC) #3
danrubel
3 years, 6 months ago (2017-05-30 20:54:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
427c06c2fecc626e47996c0d1cf1f610fccb701f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698