Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 291303007: Fix RlzLibTest (Closed)

Created:
6 years, 7 months ago by yao
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix RlzLibTest by setting OmniboxLog.is_popup_open to be true in function SimulateOmniboxUsage. BUG=369249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272856

Patch Set 1 #

Patch Set 2 : Comment. #

Patch Set 3 : Comment #

Patch Set 4 : Rebase #

Patch Set 5 : Enable rlz using the variable in common.gypi to let trybots do tests on mac. #

Patch Set 6 : Reupload #

Patch Set 7 : Rebase #

Patch Set 8 : Fix #

Patch Set 9 : Set enable_rlz back to 0 in build/common.gypi #

Patch Set 10 : Rebase #

Patch Set 11 : Rebase #

Patch Set 12 : Change enalb_rlz to 1 to run tests again. #

Patch Set 13 : Rebase #

Patch Set 14 : Set back enable_rlz #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/rlz/rlz_unittest.cc View 1 2 3 4 5 6 7 8 9 12 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
yao
Hi Roger, The windows tests passed. I haven't found a mac machine to test it ...
6 years, 7 months ago (2014-05-21 21:47:17 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm Please do confirm on mac before committing. Thanks!
6 years, 7 months ago (2014-05-22 14:46:03 UTC) #2
yao
The CQ bit was checked by yiyaoliu@chromium.org
6 years, 7 months ago (2014-05-26 04:01:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yiyaoliu@chromium.org/291303007/200001
6 years, 7 months ago (2014-05-26 04:04:22 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 16:45:17 UTC) #5
Message was sent while issue was closed.
Change committed as 272856

Powered by Google App Engine
This is Rietveld 408576698