Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2912973002: Add charset to params of CSS resource loading for dev tools

Created:
3 years, 6 months ago by apisarev
Modified:
3 years, 6 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add charset to params of CSS resource loading for dev tools According to standard CSS should use HTML document encoding in top priority. But in the case of loading CSS for dev tools, there is no setting of the charset. This lead to the use of default encoding for CSS, even when HTML have the custom charset. This problem was fixed by setting charset to CSS loading params. BUG=None R=alph

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
apisarev
3 years, 6 months ago (2017-05-30 14:43:17 UTC) #1
alph
Thank you for the patch. Unfortunately, it's not quite clear what you're trying to fix. ...
3 years, 6 months ago (2017-05-31 21:35:22 UTC) #2
apisarev
On 2017/05/31 21:35:22, alph wrote: > Thank you for the patch. > > Unfortunately, it's ...
3 years, 6 months ago (2017-06-06 09:18:24 UTC) #3
alph
3 years, 6 months ago (2017-06-08 17:54:23 UTC) #4
On 2017/06/06 09:18:24, apisarev wrote:
> On 2017/05/31 21:35:22, alph wrote:
> > Thank you for the patch.
> > 
> > Unfortunately, it's not quite clear what you're trying to fix.
> > It would be great to have a test and a bug filed.
> > 
> > I tried the following files and failed to repro the issue. Everything worked
> > just fine.
> > 
> > $ base64 charset-win-1251.css 
> > LnRzdDE6OmJlZm9yZSB7CiAgICBjb250ZW50OiAiz/Do4uXyIO7yIENTUyIKfQ==
> > 
> > $ base64 charset-win-1251.html 
> > PGh0bWw+CiAgPGhlYWQ+CiAgICA8bWV0YSBjaGFyc2V0PSJ3aW5kb3dzLTEyNTEiPgogICAgPGxp
> > bmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSJjaGFyc2V0LXdpbi0xMjUxLmNzcyI+PC9zdHlsZT4K
> > ICA8L2hlYWQ+CiAgPGJvZHk+CiAgICA8ZGl2PlRlc3Q8L2Rpdj4KICAgIDxkaXY+z/Do4uXyIO7y
> > IEhUTUw8L2Rpdj4KICAgIDxkaXYgY2xhc3M9InRzdDEiPjwvZGl2PgogIDwvYm9keT4KPC9odG1s
> > Pg==
> 
> I try to fix a loading of CSS in dev tools. My fix set CSS file encoding as in
> HTML file, cause this is what standard says.
> Unfortunately, this problem rarely appears visually in a browser. Sometimes it
> ruins CSS :before content after page reloading with dev tools. But it can be
> caught by debugger or logging of CSS encoding.
> 
> Currently, I searching a place to write a test, but can't find anything that
> fit. Can you help me with it?

I think it should be similar to ones we have in
third_party/WebKit/LayoutTests/inspector/elements/styles-*

Powered by Google App Engine
This is Rietveld 408576698