Split out MetricsServiceAccessor out of ChromeMetricsServiceAccessor.

Split out MetricsServiceAccessor out of ChromeMetricsServiceAccessor.

BUG=374199
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272618

[motek., 2014-05-21 13:06:11]

Could I bother you for a review. Note that this is contingent upon another CL
presently in the CQ.

[Ilya Sherman, 2014-05-21 13:18:30]

LGTM % nit.  Thanks :)

https://chromiumcodereview.appspot.com/291293005/diff/1/chrome/browser/metric...
File chrome/browser/metrics/metrics_service_accessor.h (right):

https://chromiumcodereview.appspot.com/291293005/diff/1/chrome/browser/metric...
chrome/browser/metrics/metrics_service_accessor.h:17: // Constructor declared as
protected to enable inheritance. Decendants have to
nit: "have to" -> "should"

[motek., 2014-05-21 13:21:11]

Hmm... I was considering even the verb "must" to highlight my view on that,
but OK, will do.
On May 21, 2014 3:18 PM, <isherman@chromium.org> wrote:

> LGTM % nit.  Thanks :)
>
>
> https://chromiumcodereview.appspot.com/291293005/diff/1/
> chrome/browser/metrics/metrics_service_accessor.h
> File chrome/browser/metrics/metrics_service_accessor.h (right):
>
> https://chromiumcodereview.appspot.com/291293005/diff/1/
> chrome/browser/metrics/metrics_service_accessor.h#newcode17
> chrome/browser/metrics/metrics_service_accessor.h:17: // Constructor
> declared as protected to enable inheritance. Decendants have to
> nit: "have to" -> "should"
>
> https://chromiumcodereview.appspot.com/291293005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[motek., 2014-05-21 14:41:08]

https://codereview.chromium.org/291293005/diff/1/chrome/browser/metrics/metri...
File chrome/browser/metrics/metrics_service_accessor.h (right):

https://codereview.chromium.org/291293005/diff/1/chrome/browser/metrics/metri...
chrome/browser/metrics/metrics_service_accessor.h:17: // Constructor declared as
protected to enable inheritance. Decendants have to
On 2014/05/21 13:18:30, Ilya Sherman wrote:
> nit: "have to" -> "should"

Done.

[motek., 2014-05-23 08:28:57]

The CQ bit was checked by motek@chromium.org

[commit-bot: I haz the power, 2014-05-23 08:29:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/motek@chromium.org/291293005/40001

[commit-bot: I haz the power, 2014-05-23 11:33:20]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-23 14:06:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-23 14:06:31]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[motek, 2014-05-23 15:15:33]

The CQ bit was checked by motek@google.com

[motek, 2014-05-23 15:15:36]

The CQ bit was unchecked by motek@google.com

[motek., 2014-05-23 15:16:55]

The CQ bit was checked by motek@chromium.org

[commit-bot: I haz the power, 2014-05-23 15:17:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/motek@chromium.org/291293005/40001

[commit-bot: I haz the power, 2014-05-23 20:17:17]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-23 22:31:46]

Change committed as 272618