Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 291293002: Fix check preventing gsutil from being included in standalone telemetry. (Closed)

Created:
6 years, 7 months ago by Dirk Pranke
Modified:
6 years, 7 months ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Fix check preventing gsutil from being included in standalone telemetry. We were checking if 'prodaccess' is in the path when trying to decide if 'gsutil' supported prodaccess; when we called this as part of the find_dependencies script, this meant that we wouldn't include gsutil because prodaccess wasn't on the bot. We really only want the path check to happen when we're handling an authorization failure, in order to determine what message to show the user. This CL fixes this issue. R=nduca@chromium.org, dtu@chromium.org BUG=369350 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M tools/telemetry/telemetry/page/cloud_storage.py View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
6 years, 7 months ago (2014-05-20 23:49:17 UTC) #1
nduca
lgtm
6 years, 7 months ago (2014-05-21 01:32:26 UTC) #2
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 7 months ago (2014-05-21 16:01:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/291293002/1
6 years, 7 months ago (2014-05-21 19:59:05 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 04:16:41 UTC) #5
Message was sent while issue was closed.
Change committed as 272091

Powered by Google App Engine
This is Rietveld 408576698