Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2912913002: Import DEPS.chromium into Dartium DEPS by copying (Closed)

Created:
3 years, 6 months ago by Bill Hesse
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, terry
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Import DEPS.chromium into Dartium DEPS by copying The new DEPS file validator does not support the python code we use to import this file from the same directory. BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=727587 R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/74907cc8911535743d373ef5e7b70da69998a4b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+741 lines, -4 lines) Patch
M tools/deps/dartium.deps/DEPS View 1 chunk +741 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Bill Hesse
3 years, 6 months ago (2017-05-30 09:11:54 UTC) #3
Bill Hesse
3 years, 6 months ago (2017-05-30 09:30:51 UTC) #5
Johnni Winther
lgtm
3 years, 6 months ago (2017-05-30 09:34:22 UTC) #6
Bill Hesse
3 years, 6 months ago (2017-05-30 09:53:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
74907cc8911535743d373ef5e7b70da69998a4b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698