Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: tests/standalone/regress_29695_test.dart

Issue 2912903002: Reapply "Fix misoptimization of 'is' test"" (Closed)
Patch Set: Remove change to TestCidsInstr::Canonicalize and improve printer Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/vm_sources.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/regress_29695_test.dart
diff --git a/tests/standalone/regress_29695_test.dart b/tests/standalone/regress_29695_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..78c9dcef0272f6535a395d8ee993c1d19ca8b43d
--- /dev/null
+++ b/tests/standalone/regress_29695_test.dart
@@ -0,0 +1,27 @@
+// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+//
+// Test that type tests are not misoptimized.
+// VMOptions=--optimization-counter-threshold=1000 --optimization-filter=IsAnInt
+
+main() {
+ train();
+ if (IsAnInt("This is not an int")) throw "oops";
+}
+
+// Prime the IC with things that are and are not ints.
+void train() {
+ for (int i = 0; i < 10000; i++) {
+ IsAnInt(42); // Smi - always goes first in the generated code.
+ IsAnInt(1 << 62); // Mint on 64 bit platforms.
+ IsAnInt(1 << 62);
+ IsAnInt(4200000000000000000000000000000000000); // BigInt
+ IsAnInt(4200000000000000000000000000000000000);
+ // This one that is not an int goes last in the IC because it is called
+ // less frequently.
+ IsAnInt(4.2);
+ }
+}
+
+bool IsAnInt(f) => f is int;
« no previous file with comments | « runtime/vm/vm_sources.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698