Reapply "Fix misoptimization of 'is' test""

runtime/vm/il_printer.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/il_printer.h"
 
 #include "vm/flow_graph_range_analysis.h"
 #include "vm/intermediate_language.h"
 #include "vm/os.h"
 #include "vm/parser.h"
@@ skipping 547 matching lines @@
   right()->PrintTo(f);
   if (needs_number_check()) {
     f->Print(", with number check");
   }
 }
 
 
 void TestCidsInstr::PrintOperandsTo(BufferFormatter* f) const {
   left()->PrintTo(f);
   f->Print(" %s [", Token::Str(kind()));
-  for (intptr_t i = 0; i < cid_results().length(); i += 2) {
+  intptr_t length = cid_results().length();
+  for (intptr_t i = 0; i < length; i += 2) {
     f->Print("0x%" Px ":%s ", cid_results()[i],
              cid_results()[i + 1] == 0 ? "false" : "true");
   }
   f->Print("] ");
+  if (CanDeoptimize()) {
+    ASSERT(deopt_id() != Thread::kNoDeoptId);
+    f->Print("else deoptimize ");
+  } else {
+    ASSERT(deopt_id() == Thread::kNoDeoptId);
+    f->Print("else %s ", cid_results()[length - 1] != 0 ? "false" : "true");
+  }
 }
 
 
 void EqualityCompareInstr::PrintOperandsTo(BufferFormatter* f) const {
   left()->PrintTo(f);
   f->Print(" %s ", Token::Str(kind()));
   right()->PrintTo(f);
 }
 
 
@@ skipping 807 matching lines @@
 }
 
 
 bool FlowGraphPrinter::ShouldPrint(const Function& function) {
   return false;
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart