Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10902)

Unified Diff: chrome/test/data/webui/md_bookmarks/toolbar_test.js

Issue 2912893002: MD Bookmarks: Support policies for disabling bookmark editing (Closed)
Patch Set: canEdit -> globalCanEdit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/md_bookmarks/toolbar_test.js
diff --git a/chrome/test/data/webui/md_bookmarks/toolbar_test.js b/chrome/test/data/webui/md_bookmarks/toolbar_test.js
index b5c697a18e4d33e4c36d5293ed18fba9062a6f7a..8fc0282c8a7367518d8b909b2bd548c6f6dc4032 100644
--- a/chrome/test/data/webui/md_bookmarks/toolbar_test.js
+++ b/chrome/test/data/webui/md_bookmarks/toolbar_test.js
@@ -13,10 +13,13 @@ suite('<bookmarks-toolbar>', function() {
setup(function() {
store = new bookmarks.TestStore({
- nodes: testTree(createFolder('1', [
- createItem('2'),
- createItem('3'),
- ])),
+ nodes: testTree(createFolder(
+ '1',
+ [
+ createItem('2'),
+ createItem('3'),
+ createFolder('4', [], {unmodifiable: 'managed'}),
+ ])),
selection: {
items: new Set(),
anchor: null,
@@ -43,13 +46,21 @@ suite('<bookmarks-toolbar>', function() {
assertTrue(toolbar.showSelectionOverlay);
});
+ test('overlay does not show when editing is disabled', function() {
+ store.data.prefs.canEdit = false
+ store.data.selection.items = new Set(['2', '3']);
+ store.notifyObservers();
+ assertFalse(toolbar.showSelectionOverlay);
+ });
+
test('clicking overlay delete button triggers a delete command', function() {
store.data.selection.items = new Set(['2', '3']);
store.notifyObservers();
Polymer.dom.flush();
- MockInteractions.tap(
- toolbar.$$('cr-toolbar-selection-overlay').deleteButton);
+ var button = toolbar.$$('cr-toolbar-selection-overlay').deleteButton;
+ assertFalse(button.disabled);
+ MockInteractions.tap(button);
commandManager.assertLastCommand(Command.DELETE, ['2', '3']);
});
@@ -64,4 +75,34 @@ suite('<bookmarks-toolbar>', function() {
commandManager.assertLastCommand(null);
});
+
+ test('delete button is disabled when items are unmodifiable', function() {
+ store.data.nodes['3'].unmodifiable = 'managed';
+ store.data.selection.items = new Set(['2', '3']);
+ store.notifyObservers();
+ Polymer.dom.flush();
+
+ assertTrue(toolbar.showSelectionOverlay);
+ assertTrue(
+ toolbar.$$('cr-toolbar-selection-overlay').deleteButton.disabled);
+ });
+
+ test('overflow menu options are disabled when appropriate', function() {
+ store.data.selectedFolder = '1';
+ store.notifyObservers();
+
+ assertFalse(toolbar.$.addBookmarkButton.disabled);
+
+ store.data.selectedFolder = '4';
+ store.notifyObservers();
+
+ assertTrue(toolbar.$.addBookmarkButton.disabled);
+ assertFalse(toolbar.$.importBookmarkButton.disabled);
+
+ store.data.prefs.canEdit = false;
+ store.notifyObservers();
+
+ assertTrue(toolbar.$.addBookmarkButton.disabled);
+ assertTrue(toolbar.$.importBookmarkButton.disabled);
+ });
});
« no previous file with comments | « chrome/test/data/webui/md_bookmarks/policy_test.js ('k') | chrome/test/data/webui/md_bookmarks/util_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698