MD Bookmarks: Support policies for disabling bookmark editing

chrome/browser/resources/md_bookmarks/util.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Utility functions for the Bookmarks page.
  */
 
 cr.define('bookmarks.util', function() {
   /**
@@ skipping 53 matching lines @@
     return nodeMap;
   }
 
   /** @return {!BookmarksPageState} */
   function createEmptyState() {
     return {
       nodes: {},
       selectedFolder: '0',
       closedFolders: new Set(),
       prefs: {
+        canEdit: true,
         incognitoAvailability: IncognitoAvailability.ENABLED,
       },
       search: {
         term: '',
         inProgress: false,
         results: [],
       },
       selection: {
         items: new Set(),
         anchor: null,
       },
     };
   }
 
   /**
    * @param {BookmarksPageState} state
    * @return {boolean}
    */
   function isShowingSearch(state) {
     return !!state.search.term && !state.search.inProgress;
   }
 
   /**
+   * Returns true if the node with ID |itemId| is unmodifiable. This should only
+   * be used to disable operations which act on the node itself (eg, rename),
+   * as it might still be possible to modify this node's children.
+   * @param {BookmarksPageState} state
+   * @param {string} itemId
+   * @return {boolean}
+   */

[calamity, 2017/06/09 06:47:31]

It's definitely worth mentioning here how unmodifiable propagates through
children.

[tsergeant, 2017/06/13 03:13:10]

Done.

+  function isNodeUnmodifiable(state, itemId) {
+    return areChildrenUnmodifiable(state, itemId) ||
+        state.nodes[itemId].parentId == ROOT_NODE_ID;
+  }
+
+  /**
+   * Returns true if it is not possible to modify the children of the node with
+   * ID |itemId|. This includes rearranging the children or adding new ones.
+   * @param {BookmarksPageState} state
+   * @param {string} itemId
+   * @return {boolean}
+   */
+  function areChildrenUnmodifiable(state, itemId) {

[calamity, 2017/06/09 06:47:31]

As discussed, it would be good to invert these 2 functions to map to
capabilities.

[tsergeant, 2017/06/13 03:13:10]

Done.

+    return !state.prefs.canEdit || !!state.nodes[itemId].unmodifiable ||
+        itemId == ROOT_NODE_ID;
+  }
+
+  /**
    * @param {string} id
    * @param {NodeMap} nodes
    * @return {boolean}
    */
   function hasChildFolders(id, nodes) {
     var children = nodes[id].children;
     for (var i = 0; i < children.length; i++) {
       if (nodes[children[i]].children)
         return true;
     }
@@ skipping 52 matching lines @@
    */
   function removeIdsFromSet(set, ids) {
     var difference = new Set(set);
     ids.forEach(function(id) {
       difference.delete(id);
     });
     return difference;
   }
 
   return {
+    areChildrenUnmodifiable: areChildrenUnmodifiable,
     createEmptyState: createEmptyState,
     getDescendants: getDescendants,
     getDisplayedList: getDisplayedList,
     hasChildFolders: hasChildFolders,
+    isNodeUnmodifiable: isNodeUnmodifiable,
     isShowingSearch: isShowingSearch,
     normalizeNode: normalizeNode,
     normalizeNodes: normalizeNodes,
     removeIdsFromMap: removeIdsFromMap,
     removeIdsFromSet: removeIdsFromSet,
   };
 });