Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3469)

Unified Diff: extensions/renderer/dispatcher.cc

Issue 2912883004: [Extensions Bindings] Don't allow `event` module with native bindings (Closed)
Patch Set: lazyboy's Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/dispatcher.cc
diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc
index 75c29b77896cfa2682da3702218387815ef71c31..623d4a5692647459a96dd1878757d8661143136e 100644
--- a/extensions/renderer/dispatcher.cc
+++ b/extensions/renderer/dispatcher.cc
@@ -707,7 +707,6 @@ std::vector<std::pair<const char*, int>> Dispatcher::GetJsResources() {
std::vector<std::pair<const char*, int>> resources = {
{"appView", IDR_APP_VIEW_JS},
{"entryIdManager", IDR_ENTRY_ID_MANAGER},
- {kEventBindings, IDR_EVENT_BINDINGS_JS},
{"extensionOptions", IDR_EXTENSION_OPTIONS_JS},
{"extensionOptionsAttributes", IDR_EXTENSION_OPTIONS_ATTRIBUTES_JS},
{"extensionOptionsConstants", IDR_EXTENSION_OPTIONS_CONSTANTS_JS},
@@ -800,6 +799,7 @@ std::vector<std::pair<const char*, int>> Dispatcher::GetJsResources() {
if (!FeatureSwitch::native_crx_bindings()->IsEnabled()) {
resources.emplace_back("binding", IDR_BINDING_JS);
+ resources.emplace_back(kEventBindings, IDR_EVENT_BINDINGS_JS);
// Custom types sources.
resources.emplace_back("StorageArea", IDR_STORAGE_AREA_JS);
« no previous file with comments | « extensions/renderer/declarative_event_unittest.cc ('k') | extensions/renderer/resources/app_runtime_custom_bindings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698